1 patch for repository darcs-unstable@darcs.net:darcs:

Tue Jan 12 21:33:26 CET 2010  Petr Rockai <me@mornfall.net>
  * Fix our version mechanism to make non-clean rebuilds pick up right version.
  
  Since Cabal relies on ghc --make, changes in -D flags are not noticed in
  dependency analysis and things do not get rebuild, which translates into stale
  version numbers in produced darcs binaries (only --exact-version was correct in
  the old system). We now tack the version information into a generated module
  instead (header file changes are not noticed by ghc --make either). This
  involves an ugly hack, since autogenerated modules cannot be listed in
  other-modules, since this breaks sdist while at the same time, libraries have
  to have all their modules listed to work. And the version information is part
  of darcslib. The workaround involves tricking the sdist implementation into not
  seeing the other-modules clause in the cabal file. This seems to work.

Attachments

• fix-our-version-mechanism-to-make-non_clean-rebuilds-pick-up-right-version_.dpatch
• unnamed

Op dinsdag 12 januari 2010 21:34 schreef Petr Ročkai:
> 1 patch for repository darcs-unstable@darcs.net:darcs:
> 
> Tue Jan 12 21:33:26 CET 2010  Petr Rockai <me@mornfall.net>
>   * Fix our version mechanism to make non-clean rebuilds pick up right 
version.

> +        sanity _ = error "eh"

I don't like this kind of non-descriptive error messages. What I'd really like 
to see in such a case is "No library found in package. If this happened to you 
during a 'cabal install', please report it as a bug to bugs@darcs.net".

I can imagine this will go wrong when a developer hacks the cabal file not to 
build the library to save time. Maybe it's just better to handle the case that 
there's no library.

For now, I am applying this patch to get 2.4 beta 2 out the door.

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-0f9f316582fd53a6081f037be6ac3e65650ffd52

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-0f9f316582fd53a6081f037be6ac3e65650ffd52