Patch 150: resolve issue1250: check for newlines in setpref values - Darcs bug tracker

Title	resolve issue1250: check for newlines in setpref values
Superseder		Nosy List	darcs-users, galbolle, kowey
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2010-02-02.14:14:47 by galbolle, last changed 2011-05-10.21:06:48 by darcswatch. Tracked on DarcsWatch.

Files
File name	Status	Uploaded	Type	Edit	Remove
resolve-issue1250_-check-for-newlines-in-setpref-values.dpatch		galbolle, 2010-02-02.14:14:46	text/x-darcs-patch
unnamed		galbolle, 2010-02-02.14:14:46	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg9924 (view)	Author: galbolle	Date: 2010-02-02.14:14:46
1 patch for repository http://darcs.net: Tue Jan 5 15:10:18 CET 2010 Florent Becker <florent.becker@ens-lyon.org> * resolve issue1250: check for newlines in setpref values Attachments resolve-issue1250_-check-for-newlines-in-setpref-values.dpatch unnamed
msg9936 (view)	Author: kowey	Date: 2010-02-02.20:45:13
resolve issue1250: check for newlines in setpref values ------------------------------------------------------- > Florent Becker <florent.becker@ens-lyon.org>**20100105141018 > Ignore-this: ea1194357318edb8953e0387bfe5841d > ] hunk ./src/Darcs/Commands/SetPref.lhs 103 > oval <- getPrefval pref > old <- case oval of Just v -> return v > Nothing -> return "" > + when ('\n' `elem` val) $ do > + putStrLn $ val ++ "is not a valid preference value: newlines forbidden!" > + exitWith $ ExitFailure 1 > changePrefval pref old val > putStrLn $ "Changing value of "++pref++" from '"++old++"' to '"++val++"'" > add_to_pending repository (changepref pref old val :>: NilFL) Looks good. Applied, thanks! -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
msg9937 (view)	Author: darcswatch	Date: 2010-02-02.21:10:45
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-0e30d8168f03c0c36ac01ec6dab98f5be0020e55
msg14324 (view)	Author: darcswatch	Date: 2011-05-10.21:06:48
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-0e30d8168f03c0c36ac01ec6dab98f5be0020e55

History
Date	User	Action	Args
2010-02-02 14:14:47	galbolle	create
2010-02-02 14:15:33	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-0e30d8168f03c0c36ac01ec6dab98f5be0020e55
2010-02-02 20:45:14	kowey	set	nosy: + kowey messages: + msg9936
2010-02-02 21:10:46	darcswatch	set	status: needs-review -> accepted messages: + msg9937
2011-05-10 21:06:48	darcswatch	set	messages: + msg14324