Patch 1581: resolved issue2543: darcs push with empty or no arguments - Darcs bug tracker

Title	resolved issue2543: darcs push with empty or no arguments
Superseder		Nosy List	bfrk
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2017-08-12.22:08:25 by bfrk, last changed 2017-08-20.16:22:06 by gh.

Files
File name	Status	Uploaded	Type	Edit	Remove
resolved-issue2543_-darcs-push-with-empty-or-no-arguments.dpatch		bfrk, 2017-08-12.22:08:25	application/x-darcs-patch
resolved-issue2543_-darcs-push-with-empty-or-no-arguments_0.dpatch		bfrk, 2017-08-13.13:39:40	application/x-darcs-patch

See mailing list archives for discussion on individual patches.

Messages
msg19572 (view)	Author: bfrk	Date: 2017-08-12.22:08:25
BTW, commandExtraArgs has a number of issues that make it almost useless in its current form; I will open a new ticket for that. Attachments resolved-issue2543_-darcs-push-with-empty-or-no-arguments.dpatch
msg19578 (view)	Author: bfrk	Date: 2017-08-13.13:39:40
Re-sending bundle with a second patch that adapts tests/pish.sh to the changed error message. Attachments resolved-issue2543_-darcs-push-with-empty-or-no-arguments_0.dpatch
msg19579 (view)	Author: bfrk	Date: 2017-08-13.13:42:23
OMG, s/pish/push/ ;)
msg19619 (view)	Author: gh	Date: 2017-08-20.16:22:05
Just to be clear, the patch produces the following response in an empty repo (which is not ideal but slightly better than before): ~~~ $ darcs push No default repository to push to, please specify one. $ darcs push "" darcs failed: Not a repository: (/_darcs/inventory does not exist) HINT: Do you have the right URI for the repository? ~~~ I don't care too much about the corner case `darcs push ""`, and the patch improves the code of D.UI.Commands.Push, so I'm going to accept it.

History
Date	User	Action	Args
2017-08-12 22:08:25	bfrk	create
2017-08-12 22:13:09	bfrk	set	status: needs-screening -> needs-review
2017-08-13 13:39:40	bfrk	set	files: + resolved-issue2543_-darcs-push-with-empty-or-no-arguments_0.dpatch messages: + msg19578
2017-08-13 13:42:23	bfrk	set	messages: + msg19579
2017-08-20 16:22:06	gh	set	status: needs-review -> accepted messages: + msg19619