Patch 1599 fix implementation of match options for clone

Title fix implementation of match options for clone
Superseder Nosy List bfrk
Related Issues
Status followup-requested Assigned To bfrk

Created on 2017-09-09.20:36:06 by bfrk, last changed 2017-10-10.10:03:56 by bfrk.

See mailing list archives for discussion on individual patches.
msg19649 (view) Author: bfrk Date: 2017-09-09.20:36:06
A partial fix for issue2546. It fixes only the implementation of
--to-xxx for clone. I am not yet screening it yet; I think that using
secondMatcher is correct but I am not 100% sure. Tests pass, of course,
but coverage for match options is weak, so this doesn't mean much.

1 patch for repository http://darcs.net/screened:

patch 5c18571dfbbf69f85373b75f92a6101109544a68
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Aug 26 09:16:55 CEST 2017
  * fix implementation of match options for clone
  Instead of translating UpToX to OneX in the match flags, directly work
  UpToX flags in hasPatchSetMatch and getOnePatchset. These are
currently used
  only for the clone command. Note that secondMatcher is extended to
  OneTag; this is justified as it also recognizes OnePatch and OneHash.
msg19716 (view) Author: bfrk Date: 2017-10-10.10:03:56
Please consider this patch as incomplete work in progress.
Date User Action Args
2017-09-09 20:36:06bfrkcreate
2017-10-10 10:03:56bfrksetstatus: needs-screening -> followup-requested
assignedto: bfrk
messages: + msg19716