darcs

Patch 175 Add missing unit test modules to darcs.c... (and 2 more)

Title Add missing unit test modules to darcs.c... (and 2 more)
Superseder Nosy List darcs-users, kowey, tux_rocker
Related Issues
Status accepted Assigned To
Milestone

Created on 2010-03-13.23:28:02 by tux_rocker, last changed 2011-05-10.20:06:50 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
add-missing-unit-test-modules-to-darcs_cabal.dpatch tux_rocker, 2010-03-13.23:28:01 text/x-darcs-patch
unnamed tux_rocker, 2010-03-13.23:28:01 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg10183 (view) Author: tux_rocker Date: 2010-03-13.23:28:01
Hi,

This is supposed to fix the missing unit test modules in the darcs 2.4
tarball, part of issue1757. It also contains a patch that makes the release
script build and run the unit tests, and buid with witnesses, before
approving of a release tarball.

Reinier

3 patches for repository http://darcs.net/:

Sat Mar 13 23:14:28 CET 2010  Reinier Lamers <tux_rocker@reinier.de>
  * Add missing unit test modules to darcs.cabal

Sat Mar 13 23:54:54 CET 2010  Reinier Lamers <tux_rocker@reinier.de>
  * Test release tarballs more thoroughly in release.sh

Sat Mar 13 23:56:11 CET 2010  Reinier Lamers <tux_rocker@reinier.de>
  * Also add PatchInfo test module to darcs.cabal
Attachments
msg10185 (view) Author: kowey Date: 2010-03-14.18:48:00
On Sat, Mar 13, 2010 at 23:28:02 +0000, Reinier Lamers wrote:
> Sat Mar 13 23:14:28 CET 2010  Reinier Lamers <tux_rocker@reinier.de>
>   * Add missing unit test modules to darcs.cabal
> 
> Sat Mar 13 23:54:54 CET 2010  Reinier Lamers <tux_rocker@reinier.de>
>   * Test release tarballs more thoroughly in release.sh
> 
> Sat Mar 13 23:56:11 CET 2010  Reinier Lamers <tux_rocker@reinier.de>
>   * Also add PatchInfo test module to darcs.cabal

I've pushed these.  Nothing out of the ordinary there...

Add missing unit test modules to darcs.cabal
--------------------------------------------
> +  -- list all unit test modules not exported by libdarcs; otherwise Cabal won't
> +  -- include them in the tarball
> +  other-modules:    Darcs.Test.Email
> +                    Darcs.Test.Patch.Check
> +                    Darcs.Test.Patch.QuickCheck
> +                    Darcs.Test.Patch.Test
> +                    Darcs.Test.Patch.Unit

This sort of thing kinda frustrates me about Cabal... or rather, what
really gets on my nerves is when I have non-exposed modules in my
libraries, and then when building something which depends on my package,
it gets a mysterious linker error...

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
msg10186 (view) Author: darcswatch Date: 2010-03-14.18:51:42
This patch bundle (with 3 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-b817a08535a2406abebbe5b355e7c3b6884fb01a
msg14260 (view) Author: darcswatch Date: 2011-05-10.20:06:50
This patch bundle (with 3 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-b817a08535a2406abebbe5b355e7c3b6884fb01a
History
Date User Action Args
2010-03-13 23:28:02tux_rockercreate
2010-03-13 23:29:40darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-b817a08535a2406abebbe5b355e7c3b6884fb01a
2010-03-14 18:48:02koweysetnosy: + kowey
messages: + msg10185
2010-03-14 18:51:43darcswatchsetstatus: needs-review -> accepted
messages: + msg10186
2011-05-10 20:06:50darcswatchsetmessages: + msg14260