Now with a fix, too.
3 patches for repository http://darcs.net/screened:
patch 89dac3b4e27fcd8a161b3649da6a39dd152d5832
Author: Ben Franksen <ben.franksen@online.de>
Date: Thu Jan 24 17:34:49 CET 2019
* accept issue2618: option --ask-deps adds too many dependencies
patch bc4a10b1347bc072bcaa0635653e00a6dc456ac7
Author: Ben Franksen <ben.franksen@online.de>
Date: Thu Jan 24 19:21:25 CET 2019
* small improvement to test for issue2618patch 1b950fc692074d8a2081925904bb8a48ed77ac18
Author: Ben Franksen <ben.franksen@online.de>
Date: Thu Jan 24 19:21:59 CET 2019
* resolve issue2618: option --ask-deps adds too many dependencies
The trick is to filter out any patches in the result from runSelection that
depend on later ones. While this may also filter out explicitly selected
patches, these should rightfully not have been offered in the first place.
I took the freedom to clean up and simplify the code for askAboutDepends.
This concerns mainly the initial filtering of patches that are depended on
by what we record, which is now reduced to a plain commuteWhatWeCanRL.
Forgot to rename the test to indicate it is no longer failing; also rebased
the accept patch to squash with the improvement.
2 patches for repository http://darcs.net/screened:
patch fd8ec00c01bff2f09b5b1c3dabb22f09b2d04a5e
Author: Ben Franksen <ben.franksen@online.de>
Date: Thu Jan 24 19:36:18 CET 2019
* accept issue2618: option --ask-deps adds too many dependencies
patch e4a9cd9363e62946e78b5a602d1e373a0f27640d
Author: Ben Franksen <ben.franksen@online.de>
Date: Thu Jan 24 19:36:55 CET 2019
* resolve issue2618: option --ask-deps adds too many dependencies
The trick is to filter out any patches in the result from runSelection that
depend on later ones. While this may also filter out explicitly selected
patches, these should rightfully not have been offered in the first place.
I took the freedom to clean up and simplify the code for askAboutDepends.
This concerns mainly the initial filtering of patches that are depended on
by what we record, which is now reduced to a plain commuteWhatWeCanRL.
> * accept issue2618: option --ask-deps adds too many dependencies
OK. I'm surprised this wasn't noticed before.
> * resolve issue2618: option --ask-deps adds too many dependencies
As you said in an older comment, the previous code was completely
unreadable, so I didn't try very hard to compare the
two :-) But the new code looks good to me.