Created on 2010-03-21.10:39:37 by tux_rocker, last changed 2011-05-10.19:35:40 by darcswatch. Tracked on DarcsWatch.
See mailing list archives
for discussion on individual patches.
msg10348 (view) |
Author: tux_rocker |
Date: 2010-03-21.10:39:36 |
|
3 patches for repository http://darcs.net/:
Sat Mar 20 17:59:13 CET 2010 Reinier Lamers <tux_rocker@reinier.de>
* resolve issue1765: refuse to remove non-tracked directories recursively
The modifyTree function from hashed-storage makes any directories on the path
to modify exist. When removing a non-tracked file, this made darcs assume that
its parent directory was tracked, even when it wasn't.
This patch makes darcs do the modifyTree only when the remove of a file
actually succeeded, so that when a remove of a non-tracked file fails, darcs
won't have a data structure that reflects a world where this removal succeeded.
Sat Mar 20 18:28:08 CET 2010 Reinier Lamers <tux_rocker@reinier.de>
* Rename issue1765 test to reflect that it succeeds
Sun Mar 21 11:17:33 CET 2010 Reinier Lamers <tux_rocker@reinier.de>
* Refactor makeRemovePatch: use foldM and split in two
Attachments
|
msg10426 (view) |
Author: kowey |
Date: 2010-03-23.00:48:40 |
|
Could you look at this, Petr? I'd normally assign (say, Florent), but I
think we need to get darcs-2.4.1 out the door.
One question I might have is: should modifyTree behave in the way
Reinier describes in the first place?
|
msg10504 (view) |
Author: tux_rocker |
Date: 2010-03-25.08:37:35 |
|
Hi all,
Op dinsdag 23 maart 2010 01:48 schreef je:
> Eric Kow <kowey@darcs.net> added the comment:
> Could you look at this, Petr? I'd normally assign (say, Florent), but I
> think we need to get darcs-2.4.1 out the door.
According to
http://bugs.darcs.net/issue?@columns=title,id,activity,status,assignedto&@sort=activity&@group=priority&@filter=topic,status&@pagesize=50&@startwith=0&topic=34&status=-1,1,2,3,4,5,6,16,17&@dispname=Open2.4
this is now the only patch that needs to go in before 2.4.1 is ready (1756 is
already fixed, but the auto-closing is broken or so). Is that an extra reason
for someone to volunteer as the reviewer?
Reinier
|
msg10505 (view) |
Author: kowey |
Date: 2010-03-25.09:21:36 |
|
On Thu, Mar 25, 2010 at 08:37:38 +0000, Reinier Lamers wrote:
> According to
> http://bugs.darcs.net/issue?@columns=title,id,activity,status,assignedto&@sort=activity&@group=priority&@filter=topic,status&@pagesize=50&@startwith=0&topic=34&status=-1,1,2,3,4,5,6,16,17&@dispname=Open2.4
> this is now the only patch that needs to go in before 2.4.1 is ready (1756 is
> already fixed, but the auto-closing is broken or so).
It's not broken; it's just tied to my staging repo (and not darcs.net,
like it should be)
> Is that an extra reason
> for someone to volunteer as the reviewer?
There was a recent thread with involving the leksah repo. I think we
should as a minimum verify that darcs 2.4.1 handles this fine. We
should probably have a darcs test case for this too.
--
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
|
msg10582 (view) |
Author: darcswatch |
Date: 2010-03-30.23:07:01 |
|
This patch bundle (with 3 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-cd839339fb067f8d51bc3f496f6c9d4457d5d920
|
msg14165 (view) |
Author: darcswatch |
Date: 2011-05-10.19:35:40 |
|
This patch bundle (with 3 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-cd839339fb067f8d51bc3f496f6c9d4457d5d920
|
|
Date |
User |
Action |
Args |
2010-03-21 10:39:37 | tux_rocker | create | |
2010-03-21 10:41:33 | darcswatch | set | darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-cd839339fb067f8d51bc3f496f6c9d4457d5d920 |
2010-03-23 00:48:40 | kowey | set | assignedto: mornfall messages:
+ msg10426 nosy:
+ kowey, mornfall |
2010-03-25 08:37:38 | tux_rocker | set | messages:
+ msg10504 |
2010-03-25 09:21:37 | kowey | set | messages:
+ msg10505 |
2010-03-30 23:07:01 | darcswatch | set | status: needs-review -> accepted messages:
+ msg10582 |
2011-05-10 19:35:40 | darcswatch | set | messages:
+ msg14165 |
|