darcs

Patch 196 DRAFT Initial NewSet port for only writing O(1) hashed...

Title DRAFT Initial NewSet port for only writing O(1) hashed...
Superseder Nosy List darcs-users, ganesh, kowey, mornfall
Related Issues make darcs record, etc. O(1) in time (is now O(n) wrt num patches)
View: 1106
Status accepted Assigned To
Milestone

Created on 2010-03-21.11:22:51 by mornfall, last changed 2011-05-10.22:05:50 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
draft-initial-newset-port-for-only-writing-o_1_-hashed_inventories-on-rec____.dpatch mornfall, 2010-03-21.11:22:50 text/x-darcs-patch
remove-implementation-of-__store_in_memory_-simplifying-matcher-code_.dpatch mornfall, 2010-05-05.22:02:04 text/x-darcs-patch
unnamed mornfall, 2010-03-21.11:22:50 text/plain
unnamed mornfall, 2010-05-05.22:02:04
See mailing list archives for discussion on individual patches.
Messages
msg10354 (view) Author: mornfall Date: 2010-03-21.11:22:50
I am somewhat keen on getting this backed up, and maybe start some initial
discussion. As things are, this passes the testsuite and builds with
witnesses. It does produce a whole bunch of warnings (I guess) and the new
scan_bundle is buggy (dies with "patch bundle bug 2")... but initial testing
seems to suggest that it also makes record go from 1.5s in GHC repo to .15s, so
a definite improvement.

Anyway, I'll get to cleaning up and amending later.

1 patch for repository http://darcs.net:

Sun Mar 21 12:17:06 CET 2010  Petr Rockai <me@mornfall.net>
  * DRAFT Initial NewSet port for only writing O(1) hashed_inventories on rec/...
Attachments
msg10422 (view) Author: kowey Date: 2010-03-22.17:12:39
Much awesomeness ahead.
Draft patches should be marked amend-in-progress.
msg10931 (view) Author: ganesh Date: 2010-05-05.11:18:10
I've looked through this, though not in great detail, and it seems 
basically fine. Given that David originally wrote it so Petr's port 
consists of a second pair of eyes on it, I think it should go in as soon 
as he's ready.
msg10961 (view) Author: mornfall Date: 2010-05-05.22:02:04
Hi,

I have resolved the conflicts with both mainline and noslurps and amended the
patch. I need one more iteration to consider merging, and it has to wait for
noslurps anyway since it now depends on that. I may end up breaking this up
into more patches (or not).

The patch bundle reading bug is likely still present, I'll look into that later
(but before requesting merge).

Yours,
   Petr.

4 patches for repository http://darcs.net:

Mon Feb  8 23:47:04 CET 2010  Petr Rockai <me@mornfall.net>
  * Remove implementation of --store-in-memory, simplifying matcher code.

Wed Apr 28 23:04:41 CEST 2010  Petr Rockai <me@mornfall.net>
  * Resolve conflicts in Match.

Fri Feb 12 11:36:41 CET 2010  Petr Rockai <me@mornfall.net>
  * Remove SlurpDirectory.

Wed May  5 23:56:00 CEST 2010  Petr Rockai <me@mornfall.net>
  * DRAFT Write out only dirty hashed inventories (which is O(1) in most cases).
Attachments
msg11033 (view) Author: mornfall Date: 2010-05-10.13:45:39
I have pushed the patch, but amended it in the meantime so darcswatch 
couldn't notice.
History
Date User Action Args
2010-03-21 11:22:51mornfallcreate
2010-03-21 11:29:30koweysetissues: + make darcs record, etc. O(1) in time (is now O(n) wrt num patches)
2010-03-21 11:36:29darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-a781be2757d59e4f204e1cdf1e5dfaefc1e78436
2010-03-22 17:12:05koweysetstatus: needs-review -> followup-in-progress
2010-03-22 17:12:40koweysetnosy: + kowey
messages: + msg10422
2010-05-05 11:18:11ganeshsetnosy: + ganesh
messages: + msg10931
2010-05-05 22:02:04mornfallsetfiles: + remove-implementation-of-__store_in_memory_-simplifying-matcher-code_.dpatch, unnamed
messages: + msg10961
2010-05-05 22:06:37darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-a781be2757d59e4f204e1cdf1e5dfaefc1e78436 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-bfd0762a2ec216ae5d61d176157c5842ee3479d8
2010-05-10 13:45:40mornfallsetstatus: followup-in-progress -> accepted
messages: + msg11033
2011-05-10 19:36:16darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-bfd0762a2ec216ae5d61d176157c5842ee3479d8 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-bfd0762a2ec216ae5d61d176157c5842ee3479d8
2011-05-10 22:05:50darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-bfd0762a2ec216ae5d61d176157c5842ee3479d8 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-a781be2757d59e4f204e1cdf1e5dfaefc1e78436