1 patch for repository http://darcs.net/screened:

patch ad6b597f3cf2e6d2627dfb6446390b044ff09b65
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Jan 27 20:23:54 CET 2020
  * fix file path encoding in convert export command
  
  This failed when the locale encoding is not UTF8, but file paths contain
  non-ASCII characters (such as tested in convert_export.sh). The reason is
  that we used anchorPath and then quoted the resulting String, which means we
  decodeLocale. Instead we have to use Darcs.Util.Path.flatten and do the
  quoting and escaping on the raw bytes. The test script was slightly extended
  to check that the quoting and escaping works as expected by git.

Attachments

• fix-file-path-encoding-in-convert-export-command.dpatch
• patch-preview.txt
• unnamed

Amended the patch to fix a mistake I made with the escaping. This was found
by git_quoted_filenames test. Also re-added escaping of '\r'; even if the
git docu doesn't explicitly require it I guess it can't hurt. Second patch
contains a few useful changes for diagnosis when the test fails.

2 patches for repository http://darcs.net/screened:

patch fe2dd87f789dfa0f6f4bbbc65cc9953a68c1e552
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Jan 27 20:23:54 CET 2020
  * fix file path encoding in convert export command
  
  This failed when the locale encoding is not UTF8, but file paths contain
  non-ASCII characters (such as tested in convert_export.sh). The reason is
  that we used anchorPath and then quoted the resulting String, which means we
  decodeLocale. Instead we have to use Darcs.Util.Path.flatten and do the
  quoting and escaping on the raw bytes. The test script was slightly extended
  to check that the quoting and escaping works as expected by git.

patch e3ede20b474ab8fb0227dc5dbe1c860829a06a2e
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Jan 27 22:49:13 CET 2020
  * some small improvements for tests/git_quoted_filenames.sh

Attachments

• fix-file-path-encoding-in-convert-export-command.dpatch
• patch-preview.txt
• unnamed

Looks reasonable. I will check the test runs ok on Windows before pushing 
:-)

Perhaps unsurprisingly, convert_export fails on Windows. 
(git_quoted_filenames was already skipped on Windows)

I'll look more closely.

Sorry for failing to follow up at all so far. I've attached the 
failing output for now.

Attachments

• convert_export.txt

> I've attached the failing output for now.

The error is obviously unrelated to darcs (and thus to the patch):

| echo 'Liebe Grüße' > e/'"Liebe\ Grüße'
| + echo 'Liebe Grüße'
| test: line 41: e/"Liebe\ Grüße: No such file or directory

This cannot have succeeded before the patch. Something must have changed
in either your cygwin's bash or Windows that makes the above command fail.

I've just rerun it in the same shell, with and without

  * fix file path encoding in convert export command

and it definitely succeeds without it and fails with it.

I had forgotten that part of the patch was a change to the test, which I
wanted to make a bit more challenging. I had not expected the
redirection to a file with a strange name to fail on Windows. A fix that
rolls back the changes to the test script is attached.

Attachments

• fix_tests_convert_export.dpatch

I get a different error now, attached.

Attachments

• convert_export.txt

I should have known better. On Windows, specifically NTFS, file names
are stored using UTF-16. This is a two-byte encoding that is not ASCII
compatible. It is thus not valid to operate on the raw byte strings in
this way on Windows. Since the particular problem this patch was
supposed to fix is an anomaly anyway and the solution works only on
*nix, I decided that this patch is bad. I will obliterate it and mark
the bundle as rejected.