1 patch for repository http://darcs.net:

Sun Mar 21 14:54:31 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * reuse is_tag

Attachments

• reuse-is_tag.dpatch
• unnamed

2 patches for repository http://darcs.net:

Sun Mar 21 14:54:31 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * reuse is_tag

Sun Mar 21 15:27:58 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * use isPrefixOf instead of take x y == "string" in some places

Attachments

• reuse-is_tag.dpatch
• unnamed

Amended version of the isPrefixOf patch.

2 patches for repository http://darcs.net:

Sun Mar 21 14:54:31 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * reuse is_tag

Sun Mar 21 15:42:55 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * use isPrefixOf instead of take x y == "string" in some places

Attachments

• reuse-is_tag.dpatch
• unnamed

gh <bugs@darcs.net> writes:
> Sun Mar 21 14:54:31 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
>   * reuse is_tag
could you also rename that one to isTag, pretty please? : - )

Thanks.

On Sun, Mar 21, 2010 at 15:44:30 +0100, Petr Rockai wrote:
> gh <bugs@darcs.net> writes:
> > Sun Mar 21 14:54:31 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
> >   * reuse is_tag
> could you also rename that one to isTag, pretty please? : - )

There's a better answer:
use the camelCase tool in darcs get http://patch-tag.com/r/kowey/snippets


-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

Now with renaming to isTag.

2 patches for repository http://darcs.net:

Sun Mar 21 15:42:55 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * use isPrefixOf instead of take x y == "string" in some places

Sun Mar 21 15:52:16 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * rename is_tag to isTag and use it more

Attachments

• unnamed
• use-isprefixof-instead-of-take-x-y-__-_string_-in-some-places.dpatch

On Sun, Mar 21, 2010 at 14:53:29 +0000, gh wrote:
> Sun Mar 21 15:42:55 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
>   * use isPrefixOf instead of take x y == "string" in some places

I'll push this

> Sun Mar 21 15:52:16 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
>   * rename is_tag to isTag and use it more

If I may be annoying, I'll request an amend of this to favour darcs
replace.  It's not a big deal either way.

use isPrefixOf instead of take x y == "string" in some places
-------------------------------------------------------------
Pretty straightforward cleanup.  Thanks!

> Guillaume Hoffmann <guillaumh@gmail.com>**20100321144255
> -          patchname_helper (PatchName n:_) | take 4 n == "TAG " = FlagPatchName $ '.':n
> -                                           | otherwise          = FlagPatchName n
> +          patchname_helper (PatchName n:_) | "TAG " `isPrefixOf` n = FlagPatchName $ '.':n
> +                                           | otherwise             = FlagPatchName n

> -               if n == "" || take 4 n == "TAG "
> +               if n == "" || "TAG " `isPrefixOf` n

> -              take 4 n == "TAG " && isJust (matchRegex (mkRegex r) $ drop 4 n)
> +              "TAG " `isPrefixOf` n && isJust (matchRegex (mkRegex r) $ drop 4 n)

Perhaps there's another refactor to try here?

> -cleanrepourl zzz | take (length dd) zzz == dd = ""
> +cleanrepourl zzz | dd `isPrefixOf` zzz = ""

Oh, that is cleaner

> -                hint = if take 1 path == "~"
> +                hint = if "~" `isPrefixOf` path

rename is_tag to isTag and use it more
--------------------------------------
> -import Darcs.Patch.Info ( pi_rename, pi_tag, is_tag, PatchInfo )
> +import Darcs.Patch.Info ( pi_rename, pi_tag, isTag, PatchInfo )

> -              where oot t = if is_tag (info t) && not (info t `elem` inOrderTags)
> +              where oot t = if isTag (info t) && not (info t `elem` inOrderTags)

... more like this.

This sort of minor token replace should be done using darcs replace for
easier commutation. (Try my camelCase tool).  Would it be any trouble to
amend that?

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

Sorry, I forgot about this patch.  Anyway, it's been obsoleted by some
of my camel work, I think