Patch 198: useless string concatenation plus useless $. - Darcs bug tracker

Title	useless string concatenation plus useless $.
Superseder		Nosy List	darcs-users, drk-sd, kowey
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2010-03-21.14:28:43 by drk-sd, last changed 2011-05-10.18:06:01 by darcswatch. Tracked on DarcsWatch.

Files
File name	Status	Uploaded	Type	Edit	Remove
useless_string_concatenation_plus_useless_$.dpatch		drk-sd, 2010-03-21.14:28:43	application/octet-stream

See mailing list archives for discussion on individual patches.

Messages
msg10383 (view)	Author: drk-sd	Date: 2010-03-21.14:28:43
Removes useless string concatenation (pursuing guillaumh's work). Attachments useless_string_concatenation_plus_useless_$.dpatch
msg10432 (view)	Author: kowey	Date: 2010-03-23.01:36:29
useless string concatenation plus useless $. -------------------------------------------- > ] hunk ./src/Darcs/RunCommand.hs 78 > - fail $ "Are you sure you didn't mean -" ++ "-all rather than -all?" > + fail "Are you sure you didn't mean --all rather than -all?" I'm applying this, thanks! Just making explicit some research methodology: I did a bit of research into this, first using darcs annotate ./src/Darcs/RunCommands.hs to identify the last patch that touched this line, then finding that it was hunk-moved (by hand) from another module, doing darcs get --lazy http://darcs.net tmp --to-p 'the hunk-move patch' and doing darcs annotate on the original file... and after all this, I found that there was no explanation in the history, but it was nice to try anyway. Now let's see if this breaks something like a syntactic highlighter somewhere -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
msg10438 (view)	Author: darcswatch	Date: 2010-03-23.02:25:54
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-d61bdad6d74c5b15fef8e2fdc801a43d99d54085
msg14089 (view)	Author: darcswatch	Date: 2011-05-10.18:06:01
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-d61bdad6d74c5b15fef8e2fdc801a43d99d54085

History
Date	User	Action	Args
2010-03-21 14:28:43	drk-sd	create
2010-03-21 14:29:40	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-d61bdad6d74c5b15fef8e2fdc801a43d99d54085
2010-03-23 01:36:29	kowey	set	nosy: + kowey messages: + msg10432
2010-03-23 02:25:54	darcswatch	set	status: needs-review -> accepted messages: + msg10438
2011-05-10 18:06:01	darcswatch	set	messages: + msg14089