Patch 1985: fix clone to ssh: need to check remote target dir does... - Darcs bug tracker

Title	fix clone to ssh: need to check remote target dir does...
Superseder		Nosy List	bfrk
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2020-02-12.14:41:45 by bfrk, last changed 2020-07-18.13:48:33 by ganesh.

Files
File name	Status	Uploaded	Type	Edit	Remove
fix-clone-to-ssh_-need-to-check-remote-target-dir-does-not-exist.dpatch	dead	bfrk, 2020-02-12.14:41:45	application/x-darcs-patch
fix-clone-to-ssh_-need-to-check-remote-target-dir-does-not-exist.dpatch		bfrk, 2020-02-12.15:25:00	application/x-darcs-patch
patch-preview.txt		bfrk, 2020-02-12.14:41:45	text/x-darcs-patch
patch-preview.txt		bfrk, 2020-02-12.15:25:00	text/x-darcs-patch
unnamed		bfrk, 2020-02-12.14:41:45	text/plain
unnamed		bfrk, 2020-02-12.15:25:00	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg21793 (view)	Author: bfrk	Date: 2020-02-12.14:41:45
I have actually been bitten by this and destroyed an existing remote repo! 1 patch for repository http://darcs.net/screened: patch 5906ad81b4fa688075645f87001bbb439ad8e22f Author: Ben Franksen <ben.franksen@online.de> Date: Wed Feb 12 15:53:01 CET 2020 * fix clone to ssh: need to check remote target dir does not exist Attachments fix-clone-to-ssh_-need-to-check-remote-target-dir-does-not-exist.dpatch patch-preview.txt unnamed
msg21794 (view)	Author: bfrk	Date: 2020-02-12.15:09:39
Please ignore for the moment, this is broken. Will send an updated patch.
msg21795 (view)	Author: bfrk	Date: 2020-02-12.15:09:40
Please ignore for the moment, this is broken. Will send an updated patch. ________________________________ Helmholtz-Zentrum Berlin für Materialien und Energie GmbH Mitglied der Hermann von Helmholtz-Gemeinschaft Deutscher Forschungszentren e.V. Aufsichtsrat: Vorsitzender Dr. Volkmar Dietz, stv. Vorsitzende Dr. Jutta Koch-Unterseher Geschäftsführung: Prof. Dr. Bernd Rech (Sprecher), Prof. Dr. Jan Lüning, Thomas Frederking Sitz Berlin, AG Charlottenburg, 89 HRB 5583 Postadresse: Hahn-Meitner-Platz 1 D-14109 Berlin
msg21796 (view)	Author: bfrk	Date: 2020-02-12.15:11:44
Please ignore for the moment, this is broken. Will send an updated patch.
msg21797 (view)	Author: bfrk	Date: 2020-02-12.15:25:00
Okay, tested & working. 1 patch for repository http://darcs.net/screened: patch 102a6eac17ebf2c516714046c312a31dbfcc2c6b Author: Ben Franksen <ben.franksen@online.de> Date: Wed Feb 12 16:37:18 CET 2020 * fix clone to ssh: need to check remote target dir does not exist Attachments fix-clone-to-ssh_-need-to-check-remote-target-dir-does-not-exist.dpatch patch-preview.txt unnamed
msg21798 (view)	Author: bfrk	Date: 2020-02-12.15:31:02
> Okay, tested & working. On Linux. Somebody should check that this works with a remote Windows repo. The patch does a "ssh user@host mkdir '<remotepath>'" to test if there is some file or directory in the way. ________________________________ Helmholtz-Zentrum Berlin für Materialien und Energie GmbH Mitglied der Hermann von Helmholtz-Gemeinschaft Deutscher Forschungszentren e.V. Aufsichtsrat: Vorsitzender Dr. Volkmar Dietz, stv. Vorsitzende Dr. Jutta Koch-Unterseher Geschäftsführung: Prof. Dr. Bernd Rech (Sprecher), Prof. Dr. Jan Lüning, Thomas Frederking Sitz Berlin, AG Charlottenburg, 89 HRB 5583 Postadresse: Hahn-Meitner-Platz 1 D-14109 Berlin
msg21800 (view)	Author: ganesh	Date: 2020-02-12.18:44:23
On 12/02/2020 16:31, Ben Franksen wrote: > > Ben Franksen <ben.franksen@online.de> added the comment: > >> Okay, tested & working. > > On Linux. Somebody should check that this works with a remote Windows > repo. The patch does a "ssh user@host mkdir '<remotepath>'" to test if > there is some file or directory in the way. I don't run an ssh server on Windows, I always pull to Windows from a remote machine. I think we can live without testing this change there.
msg21842 (view)	Author: bfrk	Date: 2020-02-16.21:44:03
Okay, screening now.
msg22070 (view)	Author: ganesh	Date: 2020-06-20.22:27:36
Fine

History
Date	User	Action	Args
2020-02-12 14:41:45	bfrk	create
2020-02-12 15:09:39	bfrk	set	messages: + msg21794
2020-02-12 15:09:41	bfrk	set	messages: + msg21795
2020-02-12 15:11:44	bfrk	set	messages: + msg21796
2020-02-12 15:25:00	bfrk	set	files: + patch-preview.txt, fix-clone-to-ssh_-need-to-check-remote-target-dir-does-not-exist.dpatch, unnamed messages: + msg21797
2020-02-12 15:31:02	bfrk	set	messages: + msg21798
2020-02-12 18:44:23	ganesh	set	messages: + msg21800
2020-02-16 21:44:03	bfrk	set	status: needs-screening -> needs-review messages: + msg21842
2020-06-20 22:27:36	ganesh	set	status: needs-review -> accepted-pending-tests messages: + msg22070
2020-07-18 13:48:33	ganesh	set	status: accepted-pending-tests -> accepted