Patch 201: Make commuteFL symmetrical with commuteRL - Darcs bug tracker

Title	Make commuteFL symmetrical with commuteRL
Superseder		Nosy List	darcs-users, galbolle, kowey
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2010-03-21.15:03:35 by galbolle, last changed 2011-05-10.19:35:57 by darcswatch. Tracked on DarcsWatch.

Files
File name	Status	Uploaded	Type	Edit	Remove
make-commutefl-symmetrical-with-commuterl.dpatch		galbolle, 2010-03-21.15:03:34	text/x-darcs-patch
unnamed		galbolle, 2010-03-21.15:03:34	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg10394 (view)	Author: galbolle	Date: 2010-03-21.15:03:34
1 patch for repository http://darcs.net: Sun Mar 21 16:07:47 CET 2010 Florent Becker <florent.becker@ens-lyon.org> * Make commuteFL symmetrical with commuteRL Attachments make-commutefl-symmetrical-with-commuterl.dpatch unnamed
msg10436 (view)	Author: kowey	Date: 2010-03-23.01:59:25
> Sun Mar 21 16:07:47 CET 2010 Florent Becker <florent.becker@ens-lyon.org> > * Make commuteFL symmetrical with commuteRL Applied, thanks! I wasted a bit of time trying to work out if that should be called commuteFLorComplain or commuteFLOrComplain or something else, but then I decided I was being silly... Maybe one point would be that the use of Either may not be as a "complaint" but as information which is actually used by Darcs to track important things. Err, it's late so I may not be making much sense. Make commuteFL symmetrical with commuteRL ----------------------------------------- > +commuteFL :: Commute p => (p :> FL p) C(x y) -> Maybe ((FL p :> p) C(x y)) > +commuteFL = either (const Nothing) Just . commuteFLorComplain The point here being that the erstwhile commuteFL (now commuteFLOrComplain) returns Either (Left the blocking patch), whereas commuteRL just returns Maybe -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
msg10439 (view)	Author: darcswatch	Date: 2010-03-23.02:26:08
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-321e55751185fb796d4191e88b5a39459d267cab
msg14175 (view)	Author: darcswatch	Date: 2011-05-10.19:35:57
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-321e55751185fb796d4191e88b5a39459d267cab

History
Date	User	Action	Args
2010-03-21 15:03:35	galbolle	create
2010-03-21 15:05:47	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-321e55751185fb796d4191e88b5a39459d267cab
2010-03-23 01:59:26	kowey	set	nosy: + kowey messages: + msg10436
2010-03-23 02:26:08	darcswatch	set	status: needs-review -> accepted messages: + msg10439
2011-05-10 19:35:57	darcswatch	set	messages: + msg14175