1 patch for repository http://darcs.net/:

Mon Apr  5 20:23:39 CEST 2010  Reinier Lamers <tux_rocker@reinier.de>
  * Make issue1739 test skip instead of fail on non-UTF-8 locales

Attachments

• make-issue1739-test-skip-instead-of-fail-on-non_utf_8-locales.dpatch
• unnamed

On Mon, Apr 05, 2010 at 20:01:03 +0000, Reinier Lamers wrote:
> Mon Apr  5 20:23:39 CEST 2010  Reinier Lamers <tux_rocker@reinier.de>
>   * Make issue1739 test skip instead of fail on non-UTF-8 locales

Reinier's justification for this patch (non-UTF-8 behaviour already
covered elsewhere) seems to make sense, so I'll go ahead and push this.

Note that for expediency, we've relaxed the policy a little so that
test case patches can be pushed directly (although the review team
member make proactively decide it needs reviewing anyway, for example
if it relaxes a test, as it does here)

http://wiki.darcs.net/Development/PatchReview

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-7678d9da461b8a04c64e351ead3082b0baa572c8

On Tue, Apr 06, 2010 at 08:49:19 +0100, Eric Kow wrote:
> On Mon, Apr 05, 2010 at 20:01:03 +0000, Reinier Lamers wrote:
> > Mon Apr  5 20:23:39 CEST 2010  Reinier Lamers <tux_rocker@reinier.de>
> >   * Make issue1739 test skip instead of fail on non-UTF-8 locales
> 
> Reinier's justification for this patch (non-UTF-8 behaviour already
> covered elsewhere) seems to make sense, so I'll go ahead and push this.

Actually, another approach, instead of disabling the test, might be
to can the message.  Write it offline (outside of the test), save it
to the darcs darcs repo and read it back in during the test.

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

Eric Kow <kowey@darcs.net> writes:

> On Tue, Apr 06, 2010 at 08:49:19 +0100, Eric Kow wrote:
>> On Mon, Apr 05, 2010 at 20:01:03 +0000, Reinier Lamers wrote:
>> > Mon Apr  5 20:23:39 CEST 2010  Reinier Lamers <tux_rocker@reinier.de>
>> >   * Make issue1739 test skip instead of fail on non-UTF-8 locales
>> 
>> Reinier's justification for this patch (non-UTF-8 behaviour already
>> covered elsewhere) seems to make sense, so I'll go ahead and push this.
>
> Actually, another approach, instead of disabling the test, might be
> to can the message.  Write it offline (outside of the test), save it
> to the darcs darcs repo and read it back in during the test.
You can't. The echo that is there already is equivalent to what you
propose. The problem is that darcs treats the file as
locale-encoded. This probably makes sense. Specifically, if it contained
invalid utf8, this would create a loophole in our utf8 metadata and we'd
be back to the original problem (just rarer, since it'd only trigger on
--logfile and possibly editing the long comment...).

Yours,
   Petr.

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-7678d9da461b8a04c64e351ead3082b0baa572c8