Patch 207: Fix hscurl.c when URL is downloaded duri... (and 1 more) - Darcs bug tracker

Title	Fix hscurl.c when URL is downloaded duri... (and 1 more)
Superseder		Nosy List	darcs-users, dmitry.kurochkin, kowey, mornfall
Related Issues
Status	accepted	Assigned To	mornfall
Milestone

Created on 2010-04-16.00:44:39 by dmitry.kurochkin, last changed 2011-05-10.20:06:56 by darcswatch. Tracked on DarcsWatch.

Files
File name	Status	Uploaded	Type	Edit	Remove
fix-hscurl_c-when-url-is-downloaded-during-the-first-call-to-curl_multi_perform_.dpatch		dmitry.kurochkin, 2010-04-16.00:44:39	text/x-darcs-patch
fix-hscurl_c-when-url-is-downloaded-during-the-first-call-to-curl_multi_perform_.dpatch		dmitry.kurochkin, 2010-04-18.22:41:19	text/x-darcs-patch
unnamed		dmitry.kurochkin, 2010-04-16.00:44:39	text/plain
unnamed		dmitry.kurochkin, 2010-04-18.22:41:19	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg10736 (view)	Author: dmitry.kurochkin	Date: 2010-04-16.00:44:39
2 patches for repository http://darcs.net: Fri Apr 16 02:47:39 MSD 2010 Dmitry Kurochkin <dmitry.kurochkin@gmail.com> * Fix hscurl.c when URL is downloaded during the first call to curl_multi_perform. Turns out that the first call to curl_multi_perform() can fetch the URL or result in error. I can easily reproduce this using HTTP server on localhost. This means that situation when running_handles is zero is valid, so remove the error and handle it correctly. Fri Apr 16 04:34:36 MSD 2010 Dmitry Kurochkin <dmitry.kurochkin@gmail.com> * URL: keep notify MVars in a single place. This will prevent deadlocks when we wait for one MVar and notification is done through another. Such situations can happen when one URL is requested several times during a short period of time. Attachments fix-hscurl_c-when-url-is-downloaded-during-the-first-call-to-curl_multi_perform_.dpatch unnamed
msg10738 (view)	Author: kowey	Date: 2010-04-16.11:45:02
Mind having a look at this one, Petr?
msg10764 (view)	Author: dmitry.kurochkin	Date: 2010-04-18.22:41:19
2 patches for repository http://darcs.net: Fri Apr 16 02:47:39 MSD 2010 Dmitry Kurochkin <dmitry.kurochkin@gmail.com> * Fix hscurl.c when URL is downloaded during the first call to curl_multi_perform. Turns out that the first call to curl_multi_perform() can fetch the URL or result in error. I can easily reproduce this using HTTP server on localhost. This means that situation when running_handles is zero is valid, so remove the error and handle it correctly. Mon Apr 19 02:37:52 MSD 2010 Dmitry Kurochkin <dmitry.kurochkin@gmail.com> * URL: keep notify MVars in a single place. This will prevent deadlocks when we wait for one MVar and notification is done through another. Such situations can happen when one URL is requested several times during a short period of time. Attachments fix-hscurl_c-when-url-is-downloaded-during-the-first-call-to-curl_multi_perform_.dpatch unnamed
msg10765 (view)	Author: dmitry.kurochkin	Date: 2010-04-18.22:46:01
The second patch bundle has amended version of the "URL: keep notify MVars in a single place" patch that fixes shadow binding warning.
msg10854 (view)	Author: darcswatch	Date: 2010-04-27.14:46:23
This patch bundle (with 2 patches) was just applied to the repository http://darcs.net/. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-c9d32042e84d1255b6d1db23db9f31955b645ee1
msg14209 (view)	Author: darcswatch	Date: 2011-05-10.19:37:16
This patch bundle (with 2 patches) was just applied to the repository http://darcs.net/reviewed. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-c9d32042e84d1255b6d1db23db9f31955b645ee1

History
Date	User	Action	Args
2010-04-16 00:44:40	dmitry.kurochkin	create
2010-04-16 00:45:56	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-3035b4e488de143e567b10552eec70f715781db8
2010-04-16 11:45:02	kowey	set	assignedto: mornfall messages: + msg10738 nosy: + kowey, mornfall
2010-04-18 22:41:19	dmitry.kurochkin	set	files: + fix-hscurl_c-when-url-is-downloaded-during-the-first-call-to-curl_multi_perform_.dpatch, unnamed messages: + msg10764
2010-04-18 22:42:21	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-3035b4e488de143e567b10552eec70f715781db8 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-c9d32042e84d1255b6d1db23db9f31955b645ee1
2010-04-18 22:46:01	dmitry.kurochkin	set	messages: + msg10765
2010-04-26 18:18:47	kowey	set	status: needs-review -> review-in-progress
2010-04-27 14:46:23	darcswatch	set	status: review-in-progress -> accepted messages: + msg10854
2011-05-10 19:37:16	darcswatch	set	messages: + msg14209
2011-05-10 20:06:56	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-c9d32042e84d1255b6d1db23db9f31955b645ee1 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-3035b4e488de143e567b10552eec70f715781db8