Patch 21 resolve issue1636: match hunk

Title resolve issue1636: match hunk
Superseder Nosy List Kamil, ganesh, kowey, tux_rocker
Related Issues new primitive match type: match regex in hunk
View: 1636
Status accepted Assigned To ganesh

Created on 2009-10-31.07:13:08 by Kamil, last changed 2009-11-12.21:58:29 by ganesh.

File name Status Uploaded Type Edit Remove
remove-trailing-whitespace.dpatch Kamil, 2009-10-31.07:13:06 text/x-darcs-patch
unnamed Kamil, 2009-10-31.07:13:06 text/plain
See mailing list archives for discussion on individual patches.
msg9100 (view) Author: Kamil Date: 2009-10-31.07:13:06

A new primitive match type that allows for picking patches based on the hunk
contents. It takes a regex and matches the pattern inside either a remove or
an add line of a hunk. An example usage is:

darcs changes -i --match "hunk pattern"

I planned to test it for some time, I used it a few times and haven't found
any problems, but I can't say I tested it extensively.

I pair-programmed on the implementation with a friend, Tom Wright.

Sat Oct  3 17:53:21 BST 2009  Kamil Dworakowski <kamil@dworakowski.name>
  * remove trailing whitespace

Sat Oct 17 17:59:28 BST 2009  Kamil Dworakowski <kamil@dworakowski.name>
  * accept issue1636 match hunk
  Add primitive match type to select patches which contain
  a given regex in some of their hunks.

Sun Oct 25 12:29:54 GMT 2009  Kamil Dworakowski <kamil@dworakowski.name>
  * resolve issue1636: match hunk
  A new primitive match type.
  By Kamil and tat.wright
msg9134 (view) Author: kowey Date: 2009-10-31.19:06:08
Hi Reinier,

May I assign this one to you to review?
msg9139 (view) Author: kowey Date: 2009-10-31.19:29:01
Sorry for the musical chairs, folks.  I'd like to pull Reinier off this patch
and re-allocate him to the recent Petr patches.  Ganesh: could you have a look
at this one?
msg9152 (view) Author: ganesh Date: 2009-10-31.22:21:09
Date User Action Args
2009-10-31 07:13:08Kamilcreate
2009-10-31 10:18:36twbsettitle: remove trailing whitespace (and 2 more) -> resolve issue1636: match hunk
2009-10-31 17:11:13koweysetissues: + new primitive match type: match regex in hunk
2009-10-31 19:06:09koweysetassignedto: tux_rocker
messages: + msg9134
nosy: + kowey, tux_rocker
2009-10-31 19:29:01koweysetnosy: + ganesh
messages: + msg9139
assignedto: tux_rocker -> ganesh
2009-10-31 22:21:10ganeshsetmessages: + msg9152
2009-11-06 08:49:27ganeshsetstatus: needs-review -> review-in-progress
2009-11-12 21:58:29ganeshsetstatus: review-in-progress -> accepted