Patch 2142: remove Darcs.Patch.ApplyPatches (and 2 more) - Darcs bug tracker

Title	remove Darcs.Patch.ApplyPatches (and 2 more)
Superseder		Nosy List	bfrk
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2020-12-21.16:30:47 by bfrk, last changed 2021-03-27.23:55:55 by ganesh.

Files
File name	Status	Uploaded	Type	Edit	Remove
minor-refactor-in-d_ui_applypatches.dpatch		bfrk, 2020-12-21.16:30:46	application/x-darcs-patch
patch-preview.txt		bfrk, 2020-12-21.16:30:46	text/x-darcs-patch
unnamed		bfrk, 2020-12-21.16:30:46	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg22586 (view)	Author: bfrk	Date: 2020-12-21.16:30:46
It has always bugged me that we have so many modules named ApplyPatches. This refactor at least removes the one under Darcs.Apply; the functionality is now part of Darcs.Repository.ApplyPatches, its only consumer. 3 patches for repository http://darcs.net/screened: patch 4634fe991652152c99fda9b9dc4da29615bb3bad Author: Ben Franksen <ben.franksen@online.de> Date: Thu Nov 5 10:40:20 CET 2020 * minor refactor in D.UI.ApplyPatches patch a80ed9a6f564c45183c0c407f04de01d45e742e7 Author: Ben Franksen <ben.franksen@online.de> Date: Tue Nov 24 09:20:29 CET 2020 * remove Darcs.Patch.ApplyPatches patch e9447ae22c0c8ac14886c1cdc46173508db88f8d Author: Ben Franksen <ben.franksen@online.de> Date: Tue Nov 24 09:26:21 CET 2020 * cleanup import lists in Darcs.Repository.ApplyPatches Attachments minor-refactor-in-d_ui_applypatches.dpatch patch-preview.txt unnamed
msg22668 (view)	Author: ganesh	Date: 2021-03-22.17:06:10
All fine. I think I introduced the modules to separate the UI/Repository/Patch layers, but D.P.ApplyPatches is clearly a bit small to be worthy of its own module.

History
Date	User	Action	Args
2020-12-21 16:30:47	bfrk	create
2020-12-21 16:31:41	bfrk	set	status: needs-screening -> needs-review title: minor refactor in D.UI.ApplyPatches (and 2 more) -> remove Darcs.Patch.ApplyPatches (and 2 more)
2021-03-22 17:06:11	ganesh	set	status: needs-review -> accepted-pending-tests messages: + msg22668
2021-03-27 23:55:55	ganesh	set	status: accepted-pending-tests -> accepted