darcs

Patch 2167 include the RepoPatchV1 tests via the no... (and 4 more)

Title include the RepoPatchV1 tests via the no... (and 4 more)
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To
Milestone

Created on 2021-05-08.15:32:09 by ganesh, last changed 2021-06-03.12:10:03 by bfrk.

Files
File name Status Uploaded Type Edit Remove
include-the-repopatchv1-tests-via-the-normal-patch-tests.dpatch ganesh, 2021-05-08.15:32:08 application/x-darcs-patch
patch-preview.txt ganesh, 2021-05-08.15:32:08 text/x-darcs-patch
unnamed ganesh, 2021-05-08.15:32:08 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg22756 (view) Author: ganesh Date: 2021-05-08.15:32:08
Some cleanup of the RepoPatchV1 tests.
As always there is more that could be done :-)

5 patches for repository darcs-unstable@darcs.net:screened:

patch b70bd0615b26d3d203734f7da8b757de8b8cb47b
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat May  8 14:52:06 BST 2021
  * include the RepoPatchV1 tests via the normal Patch tests
  
  I think they may have been included separately before to
  avoid instance conflicts, which are no longer an issue.

patch 50d460611bb5709e80576e714e638578dce15b94
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat May  8 15:12:57 BST 2021
  * inline D.T.Patch.RepoPatchV1 into D.T.Patch

patch f8d98877df3f496900df47703c19c503c94625f7
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat May  8 15:33:10 BST 2021
  * add the "standard" repoPatchProperties to qc_V1P1
  
  This means we can drop the custom showRead property.

patch 85b27d802310fe8c0dde81f7e6b4d67f9da287a0
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat May  8 15:33:32 BST 2021
  * Drop a deliberately duplicated QC property
  
  We don't gain anything useful from running it twice.

patch 914766c965bc792301f60eba482aae2196e3cfbd
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat May  8 16:46:01 BST 2021
  * drop tests in qc_V1P1 that are just about prims
  
  There are better versions in qc_prim anyway.
Attachments
msg22829 (view) Author: bfrk Date: 2021-06-03.12:09:50
All accepted, details below.

>   * include the RepoPatchV1 tests via the normal Patch tests

OK.

>   I think they may have been included separately before to
>   avoid instance conflicts, which are no longer an issue.

Exactly.

>   * inline D.T.Patch.RepoPatchV1 into D.T.Patch

OK

>   * add the "standard" repoPatchProperties to qc_V1P1

OK

>   * Drop a deliberately duplicated QC property

OK

>   * drop tests in qc_V1P1 that are just about prims

OK, though I would have removed propCommuteInverse as well (this is
D.T.P.Properties.Generic.squareCommuteLaw).
History
Date User Action Args
2021-05-08 15:32:10ganeshcreate
2021-05-08 15:37:53ganeshsetstatus: needs-screening -> needs-review
2021-06-03 12:09:51bfrksetmessages: + msg22829
2021-06-03 12:10:03bfrksetstatus: needs-review -> accepted