Patch 2186: Darcs.Util.ByteString: avoid throwing ex... (and 1 more) - Darcs bug tracker

Title	Darcs.Util.ByteString: avoid throwing ex... (and 1 more)
Superseder		Nosy List	bfrk
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2021-06-05.07:30:00 by bfrk, last changed 2021-06-08.05:25:48 by ganesh.

Files
File name	Status	Uploaded	Type	Edit	Remove
darcs_util_bytestring_-avoid-throwing-exceptions-from-pure-code.dpatch		bfrk, 2021-06-05.07:30:00	application/x-darcs-patch
patch-preview.txt		bfrk, 2021-06-05.07:30:00	text/x-darcs-patch
unnamed		bfrk, 2021-06-05.07:30:00	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg22846 (view)	Author: bfrk	Date: 2021-06-05.07:30:00
See discussion on IRC 2 patches for repository http://darcs.net/screened: patch 115d5855e2a65e23623c067c3d9413713600c470 Author: Ben Franksen <ben.franksen@online.de> Date: Wed Jun 2 22:34:01 CEST 2021 * Darcs.Util.ByteString: avoid throwing exceptions from pure code patch 3010611c8928469c81d00a029531d5cfd0f2fa8c Author: Ben Franksen <ben.franksen@online.de> Date: Wed Jun 2 22:36:13 CEST 2021 * Darcs.Util.SignalHandler: replace throw with throwIO Attachments darcs_util_bytestring_-avoid-throwing-exceptions-from-pure-code.dpatch patch-preview.txt unnamed
msg22855 (view)	Author: ganesh	Date: 2021-06-05.09:23:42
For a bit more background as tracking down the IRC conversation wouldn't be trivial: this stemmed from https://gitlab.haskell.org/ghc/ghc/-/issues/19917 That made it clear that you can't really rely on calling "error" in pure code and actually getting that specific error. Code changes look fine.

History
Date	User	Action	Args
2021-06-05 07:30:00	bfrk	create
2021-06-05 07:35:31	bfrk	set	status: needs-screening -> needs-review
2021-06-05 09:23:42	ganesh	set	status: needs-review -> accepted-pending-tests messages: + msg22855
2021-06-08 05:25:48	ganesh	set	status: accepted-pending-tests -> accepted