Patch 2198: remove unused RestrictedApply from D.P.A... (and 2 more) - Darcs bug tracker

Title	remove unused RestrictedApply from D.P.A... (and 2 more)
Superseder		Nosy List	bfrk
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2021-06-08.13:14:33 by bfrk, last changed 2021-12-03.05:55:58 by bfrk.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		bfrk, 2021-06-08.13:14:32	text/x-darcs-patch
patch-preview.txt		bfrk, 2021-12-03.05:55:57	text/x-darcs-patch
remove-unused-restrictedapply-from-d_p_applymonad.dpatch		bfrk, 2021-06-08.13:14:32	application/x-darcs-patch
replace-undefined-with-error-calls-for-missing-methods.dpatch		bfrk, 2021-12-03.05:55:57	application/x-darcs-patch
unnamed		bfrk, 2021-06-08.13:14:32	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg22876 (view)	Author: bfrk	Date: 2021-06-08.13:14:32
3 patches for repository http://darcs.net/screened: patch 1ddd4c53fa0686ca97de3a8940e3c20fe4825cfd Author: Ben Franksen <ben.franksen@online.de> Date: Mon Mar 15 21:46:21 CET 2021 * remove unused RestrictedApply from D.P.ApplyMonad patch b849c3e209868ccb988fe66de5be27a51e993a5c Author: Ben Franksen <ben.franksen@online.de> Date: Mon Mar 15 21:47:54 CET 2021 * cleanup method definitions in D.P.ApplyMonad This removes -fno-warn-missing-methods and explicitly defines missing methods as undefined. The darcsAddMissingHashesdefault definition of mCreateFile in terms of mModifyFilePS is removed. Defining a proper mCreateFile means we can remove the existence check from the definition of mModifyFilePS in the instance ApplyMonadTree (TM.TreeMonad m). patch c7f95ca0508b9398ddd960f38a1137a8511134a1 Author: Ben Franksen <ben.franksen@online.de> Date: Sat Apr 3 07:24:00 CEST 2021 * replace class ApplyMonadState with a top-level type family The class ApplyMonadState was only there to carry the type (constraint) family ApplyMonadStateOperations, which I renamed to ApplyMonadOperations for brevity. Attachments patch-preview.txt remove-unused-restrictedapply-from-d_p_applymonad.dpatch unnamed
msg22937 (view)	Author: ganesh	Date: 2021-11-27.16:19:17
> * remove unused RestrictedApply from D.P.ApplyMonad OK > * cleanup method definitions in D.P.ApplyMonad > > This removes -fno-warn-missing-methods and explicitly defines missing > methods as undefined. The darcsAddMissingHashesdefault definition of mCreateFile in terms of > mModifyFilePS is removed. Defining a proper mCreateFile means we can remove > the existence check from the definition of mModifyFilePS in the instance > ApplyMonadTree (TM.TreeMonad m). Using undefined is actually worse for error messages, maybe use an error message we can grep for? Rest looks fine, at the other call sites for mModifyFilePS it should already exist. > * replace class ApplyMonadState with a top-level type family > > The class ApplyMonadState was only there to carry the type (constraint) > family ApplyMonadStateOperations, which I renamed to ApplyMonadOperations > for brevity. OK
msg22941 (view)	Author: bfrk	Date: 2021-12-03.05:55:57
Following up on review (I fully agree, using undefined was sloppy). 1 patch for repository http://darcs.net/screened: patch b2551ffc9ac1bf7b43c954d279edc6c50afe0f07 Author: Ben Franksen <ben.franksen@online.de> Date: Fri Dec 3 06:46:57 CET 2021 * replace undefined with error calls for missing methods Attachments patch-preview.txt replace-undefined-with-error-calls-for-missing-methods.dpatch

History
Date	User	Action	Args
2021-06-08 13:14:33	bfrk	create
2021-06-08 13:36:46	bfrk	set	status: needs-screening -> needs-review
2021-11-27 16:19:19	ganesh	set	messages: + msg22937
2021-11-27 16:19:25	ganesh	set	status: needs-review -> accepted-pending-tests
2021-11-27 17:04:42	ganesh	set	status: accepted-pending-tests -> accepted
2021-12-03 05:55:58	bfrk	set	files: + patch-preview.txt, replace-undefined-with-error-calls-for-missing-methods.dpatch messages: + msg22941