Patch 2218 convert darcs-2: add a final call to fin... (and 3 more)

Title convert darcs-2: add a final call to fin... (and 3 more)
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To

Created on 2021-11-05.10:47:17 by bfrk, last changed 2023-03-27.08:04:55 by ganesh.

File name Status Uploaded Type Edit Remove
convert-darcs_2_-add-a-final-call-to-finalizerepositorychanges.dpatch bfrk, 2021-11-05.10:47:17 application/x-darcs-patch
patch-preview.txt bfrk, 2021-11-05.10:47:17 text/x-darcs-patch
See mailing list archives for discussion on individual patches.
msg22921 (view) Author: bfrk Date: 2021-11-05.10:47:17
Cleanups for darcs convert and its subcommands.

4 patches for repository http://darcs.net/screened:

patch a1ccaa96f73f2eff1d30122b10d9c35c94b2a44b
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Mar  3 15:28:15 CET 2021
  * convert darcs-2: add a final call to finalizeRepositoryChanges

  This is more a matter of principle than necessity, since the code does work
  without the call.

patch 7f85c9fc18a3306218f3963b138b060b6efb638c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Mar  3 15:36:41 CET 2021
  * convert darcs-2: honor the compress option

patch 3cc7aeddb49ab2419688e93a6a416c0a412054d9
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Jun 17 12:10:48 CEST 2021
  * convert darcs-2: remove intermediate commits

  There are two reasons for this change. One is that intermediate commits open
  a brief window in which the repo is not locked. Since this happens in a
  newly created repo, this is not of much practical concern and more a matter
  of principle. Second, intermediate commits serve no purpose. If conversion
  runs into an exception you will end up with a partially converted repo (the
  state of the last commit). This is quite useless, since there is no way to
  restart the conversion at this point.

patch 5bdba80456862ab5c17018fd30e02d9d379b7eaf
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Mar  3 15:50:01 CET 2021
  * convert import/darcs-2: recognize the compress and diffAlgorithm options

  This avoids hard-coding some arbitrarily chosen value.
msg23184 (view) Author: ganesh Date: 2023-03-26.13:24:00
All OK
Date User Action Args
2021-11-05 10:47:17bfrkcreate
2021-11-05 10:48:53bfrksetstatus: needs-screening -> needs-review
2023-03-26 13:24:00ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg23184
2023-03-27 08:04:55ganeshsetstatus: accepted-pending-tests -> accepted