Patch 2249 tests/lib: make 'not' fail if command re... (and 1 more)

Title tests/lib: make 'not' fail if command re... (and 1 more)
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To

Created on 2022-06-12.18:16:59 by bfrk, last changed 2023-06-24.17:17:03 by ganesh.

File name Status Uploaded Type Edit Remove
patch-preview.txt bfrk, 2022-06-12.18:16:57 text/x-darcs-patch
tests_lib_-make-_not_-fail-if-command-returns-4.dpatch bfrk, 2022-06-12.18:16:57 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
msg23012 (view) Author: bfrk Date: 2022-06-12.18:16:57
2 patches for repository http://darcs.net/screened:

patch 1e90b620e23b46c9d945ebef9a700e269f41b6c6
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri May 13 22:34:06 CEST 2022
  * tests/lib: make 'not' fail if command returns 4

  This exit code is returned by darcs when the top-level handler receives an
  ErrorCall exception. This signifies a bug in darcs, so should be treated as
  failure of the test even if the script uses 'not' to indicate that darcs is
  expected to fail.

patch 9f4251b600a45483df61606fbb9d004b2d5a6671
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu May  5 20:26:45 CEST 2022
  * harness: use runghc for hspwd instead of compilation

  This fixes occasional CI test failures that say

  ghc --make -o hspwd /home/runner/work/darcs-ci/darcs-ci/tests/bin/hspwd.hs
  renameFile:renamePath:rename: does not exist (No such file or directory)
  lib: line 32: ./hspwd: No such file or directory
msg23387 (view) Author: ganesh Date: 2023-06-24.16:25:21
looks good - I ran into the hspwd race condition occasionally recently
locally too. (I'm pretty sure two parallel instances of the tests
were colliding over a global path)
Date User Action Args
2022-06-12 18:16:59bfrkcreate
2022-06-12 18:17:39bfrksetstatus: needs-screening -> needs-review
2023-06-24 16:25:22ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg23387
2023-06-24 17:17:03ganeshsetstatus: accepted-pending-tests -> accepted