Patch 23 Add optional specifier for "darcs help environment

Title Add optional specifier for "darcs help environment
Superseder Nosy List kowey, twb
Related Issues
Status accepted Assigned To twb

Created on 2009-10-31.12:27:37 by twb, last changed 2011-12-31.19:22:46 by kowey.

File name Status Uploaded Type Edit Remove
add-optional-specifier-for-_darcs-help-environment-_variable___.dpatch twb, 2009-10-31.12:27:35 text/x-darcs-patch
unnamed twb, 2009-10-31.12:27:35 text/plain
See mailing list archives for discussion on individual patches.
msg9107 (view) Author: twb Date: 2009-10-31.12:27:35
This has been sitting in my repo for some time, because I've been too
embarrassed to send it.  The code is fugly, and I'm not convinced that
the functionality is desirable.

I suppose this (requesting the docstring of a single entry) might be
more useful in the "darcs help preferences" and "darcs help files" I
intend to implement, e.g. "darcs help files boring" would describe

Sun Jun 28 22:10:17 EST 2009  Trent W. Buck <trentbuck@gmail.com>
  * Add optional specifier for "darcs help environment [VARIABLE]".
  This kind of command-line argument parsing seems like a huge bodge.
  Surely there is a better way to write this, maybe with getopt?
msg9115 (view) Author: twb Date: 2009-10-31.12:59:47
Eric reviewed this patch on the mailing list before the patch tracker
existed, but I'm not sure what the resolution was.  Reassigning to him
for now.
msg9122 (view) Author: kowey Date: 2009-10-31.15:27:58
Here is the link to my review:
It looks like a very passive "amend requested" (more like, maybe these
suggestions will make you happier with the patch)...
msg14917 (view) Author: kowey Date: 2011-12-31.17:10:22
Gah, what is your problem, 2009-Eric? The code seems fine! Well, OK 
maybe it's worth doing something about that 'error', but otherwise, geez 
way to nitpick and leave a patch languishing on the tracker for two 

Sorry Trent!  It wasn't policy so much as disorganisation.  I've never 
succeeded in training myself to follow up on things.  Hopefully will get 
better at it as I start learning a better way to track things I'm 
waiting on.
Date User Action Args
2009-10-31 12:27:37twbcreate
2009-10-31 12:59:47twbsetassignedto: kowey
messages: + msg9115
nosy: + kowey
2009-10-31 15:27:59koweysetstatus: needs-review -> followup-requested
assignedto: kowey -> twb
messages: + msg9122
2011-07-27 12:17:00junior1971setfiles: + cheapcodfedextramadolvery.html
2011-07-27 12:58:18junior1971setfiles: + generictramadolhclonline.html
2011-12-31 17:01:20koweysetfiles: - cheapcodfedextramadolvery.html
2011-12-31 17:01:22koweysetfiles: - generictramadolhclonline.html
2011-12-31 17:10:22koweysetstatus: followup-requested -> accepted-pending-tests
messages: + msg14917
2011-12-31 19:22:46koweysetstatus: accepted-pending-tests -> accepted