Patch 2300 diff command: support --look-for-moves and --look-for-...

Title diff command: support --look-for-moves and --look-for-...
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To

Created on 2023-05-30.19:33:27 by bfrk, last changed 2023-07-01.20:14:04 by ganesh.

File name Status Uploaded Type Edit Remove
diff-command_-support-__look_for_moves-and-__look_for_adds-options.dpatch bfrk, 2023-05-30.19:33:26 application/x-darcs-patch
patch-preview.txt bfrk, 2023-05-30.19:33:26 text/x-darcs-patch
See mailing list archives for discussion on individual patches.
msg23299 (view) Author: bfrk Date: 2023-05-30.19:33:26
It is interesting to note that adding the options is all we need to do here,
the machinery is such that these options will be taken into account
automatically when set.

1 patch for repository http://darcs.net/screened:

patch 4b741509ef5539aba0d9f03d93b24e13e5d4706a
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Mar 10 12:41:16 CET 2023
  * diff command: support --look-for-moves and --look-for-adds options

  This is useful when using `darcs diff` with unrecorded changes.
  (Note that --look-for-replaces makes no sense for diff.)
msg23300 (view) Author: bfrk Date: 2023-05-30.19:36:16
Will self-accept but not immediately. IMO this is a no-brainer and 
adds useful functionality at no price at all.
msg23401 (view) Author: ganesh Date: 2023-06-24.20:16:10
What does `--look-for-moves` mean for diff? Doesn't it end up displaying
them as a delete/add combo anyway?
msg23440 (view) Author: bfrk Date: 2023-06-27.06:53:56
Yes it does. It's not extremely useful, but can come in handly, for 
instance, to produce a (standard, UNIX) patch file.
msg23464 (view) Author: ganesh Date: 2023-07-01.15:15:44
> Yes it does. It's not extremely useful, but can come in handly, for
> instance, to produce a (standard, UNIX) patch file.

What I'm not seeing is how the output or behaviour with `--look-for-moves` 
differs from if you run with `--look-for-adds`?
msg23472 (view) Author: bfrk Date: 2023-07-01.19:44:51
With --look-for-moves you get the diffs for precisely the files that 
you renamed plus whatever it would show without the option. With --
look-for-adds you get the diffs for every (non-boring) file that 
happens to exist in your repo.
msg23474 (view) Author: ganesh Date: 2023-07-01.19:48:26
Ah, I see. Thanks.
Date User Action Args
2023-05-30 19:33:27bfrkcreate
2023-05-30 19:36:16bfrksetstatus: needs-screening -> needs-review
messages: + msg23300
2023-06-24 20:16:10ganeshsetstatus: needs-review -> review-in-progress
messages: + msg23401
2023-06-27 06:53:56bfrksetmessages: + msg23440
2023-07-01 15:15:47ganeshsetmessages: + msg23464
2023-07-01 19:44:52bfrksetmessages: + msg23472
2023-07-01 19:48:27ganeshsetstatus: review-in-progress -> accepted-pending-tests
messages: + msg23474
2023-07-01 20:14:04ganeshsetstatus: accepted-pending-tests -> accepted