Patch 2312 WIP disable tests/network/log in the CI

Title WIP disable tests/network/log in the CI
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To

Created on 2023-06-17.11:31:24 by bfrk, last changed 2023-08-19.12:28:17 by bfrk.

File name Status Uploaded Type Edit Remove
patch-preview.txt bfrk, 2023-06-17.11:31:19 text/x-darcs-patch
patch-preview.txt bfrk, 2023-08-16.12:24:09 text/x-darcs-patch
tests_network_log_sh_-darcs_net-__-hub_darcs_net_darcs_darcs_screened.dpatch bfrk, 2023-08-16.12:24:09 application/x-darcs-patch
wip-disable-tests_network_log-in-the-ci.dpatch bfrk, 2023-06-17.11:31:20 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
msg23326 (view) Author: bfrk Date: 2023-06-17.11:31:20
Screening this despite the WIP in the patch name. We should not accept this
one and instead try to find a way to re-write the test so that it does not
rely on darcs.net.

1 patch for repository http://darcs.net/screened:

patch be0e90ba7aa62a9a6a26b8db35f15772dbb1b60f
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Feb 16 19:32:12 CET 2023
  * WIP disable tests/network/log in the CI

  This test regularly runs into failures that seem to be caused by darcs.net
  when it receives to many requests in parallel. I haven't figured out what
  exactly is going on, this is just a temporary stop-gap measure.
msg23547 (view) Author: ganesh Date: 2023-07-12.21:27:59
FYI I hit this a lot at the weekend when I had bad internet connections,
so it may not be entirely darcs.net's fault (though I assume CI has
a decent connection itself!)
msg23587 (view) Author: bfrk Date: 2023-07-16.12:00:46
FWIW, I think I have seen this happening on Linux, too, with enough 
actual paralellism (cores) involved.
msg23609 (view) Author: ganesh Date: 2023-07-16.23:22:03
I think we could change this test to work against a locally served
repo (with the serve_http utility) like some other network tests do.
It's not actually doing anything particularly complicated and
any dependency it had on the contents of http://darcs.net has
long since been invalidated as it only looks at most at the last 30 
patches anyway.
msg23677 (view) Author: bfrk Date: 2023-08-16.12:24:09
With this follow-up I think it could now be accepted.

1 patch for repository http://darcs.net/screened:

patch 536b22a9f7f64a34dab657f370ef527082182edb
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Aug 16 14:16:44 CEST 2023
  * tests/network/log.sh: darcs.net -> hub.darcs.net/darcs/darcs-screened

  This seems to fix the CI problems, so this patch also rolls back

    patch be0e90ba7aa62a9a6a26b8db35f15772dbb1b60f
    Author: Ben Franksen <ben.franksen@online.de>
    Date:   Thu Feb 16 19:32:12 CET 2023
      * WIP disable tests/network/log in the CI
msg23678 (view) Author: bfrk Date: 2023-08-16.12:26:33
Alternatively, we may obliterate and push a single amended patch. I 
have no particular preference for either.
msg23679 (view) Author: bfrk Date: 2023-08-19.12:03:53
Date User Action Args
2023-06-17 11:31:24bfrkcreate
2023-06-17 11:32:16bfrksetstatus: needs-screening -> needs-review
2023-07-12 21:28:00ganeshsetmessages: + msg23547
2023-07-16 12:00:46bfrksetmessages: + msg23587
2023-07-16 23:22:03ganeshsetmessages: + msg23609
2023-08-16 12:24:10bfrksetfiles: + patch-preview.txt, tests_network_log_sh_-darcs_net-__-hub_darcs_net_darcs_darcs_screened.dpatch
messages: + msg23677
2023-08-16 12:26:34bfrksetmessages: + msg23678
2023-08-19 12:03:53bfrksetstatus: needs-review -> accepted-pending-tests
messages: + msg23679
2023-08-19 12:28:17bfrksetstatus: accepted-pending-tests -> accepted