This pending patch test, courtesy of Ferenc Wagner is beautifully simple and
weird.

Ferenc: I've simplified it a bit, getting rid of the blah blah file.

I bet any Darcs hacker with some time and willingness to stare at the Darcs
code can figure out what exactly is going wrong.  Nice work, Ferenc!

1 patch for repository http://darcs.net:

Wed May  5 15:49:53 BST 2010  Eric Kow <kowey@darcs.net>
  * Accept issue1825: darcs remove with no args leads to buggy pending.

Attachments

• accept-issue1825_-darcs-remove-with-no-args-leads-to-buggy-pending_.dpatch
• unnamed

Eric Kow <bugs@darcs.net> writes:
> +. lib                           # Load some portability helpers.
> +rm -rf R                        # Another script may have left a mess.
> +darcs init      --repo R        # Create our test repos.
> +
> +cd R
> +mkdir -p a
> +echo foo >a/b
> +darcs add -r a
> +darcs rec -am "add a/b"
> +rm -r a
> +darcs remove
darcs add without parameters works just as fine here... so this is
probably related to generic pending manipulation, not just darcs remove

Nevertheless, the pending that is created here is legal as far as I can
tell, so the bug is not this. To see what I mean, you can replace "rm -r
a; darcs remove" with just "darcs remove -r a" to obtain identical
pending.

> +darcs revert -a a/b

So this here triggers a sequence where "a/b" is attempted to be
reverted, which fails in the working copy as far as I can tell, since a/
does not exist anymore. Sneaking in "mkdir a" before the revert fixes
the problem, too...

The problem seems to be that something somewhere does not notice the
rmdir a/ patch and the fact it needs to be undone before the a/b patch
is...

Yours,
   Petr.

This amendment incorporates Petr's useful observation that it's not
about the 'darcs remove', specifically, just creating the pending
patch.

The pending patch right before the revert is legit

So it looks like it's something happening at revert time...

1 patch for repository http://darcs.net:

Wed May  5 16:59:19 BST 2010  Eric Kow <kowey@darcs.net>
  * Accept issue1825: darcs remove with no args leads to buggy pending.

Attachments

• accept-issue1825_-darcs-remove-with-no-args-leads-to-buggy-pending_.dpatch
• unnamed

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-f4b63cd9abca0ce2d57084628670626fbe5802fc

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-f4b63cd9abca0ce2d57084628670626fbe5802fc