Patch 2339 make --boring mutually exclusive with --... (and 1 more)

Title make --boring mutually exclusive with --... (and 1 more)
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To

Created on 2023-07-30.09:42:51 by bfrk, last changed 2024-02-18.15:47:43 by ganesh.

File name Status Uploaded Type Edit Remove
improve-help-for-__look_for_adds___boring.dpatch bfrk, 2023-07-30.14:54:23 application/x-darcs-patch
make-__boring-mutually-exclusive-with-__look_for_adds-if-both-are-supported.dpatch bfrk, 2023-07-30.09:42:50 application/x-darcs-patch
patch-preview.txt bfrk, 2023-07-30.09:42:50 text/x-darcs-patch
patch-preview.txt bfrk, 2023-07-30.14:54:23 text/x-darcs-patch
patch-preview.txt bfrk, 2023-07-31.08:32:02 text/x-darcs-patch
support-short-options-in-defaults-files.dpatch bfrk, 2023-07-31.08:32:02 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
msg23646 (view) Author: bfrk Date: 2023-07-30.09:42:50
The first patch is an incompatible change in behavior which is why I am not
screening it yet. If you think it is not worth breaking compatibility, I can
rebase the second patch and send it separately.

2 patches for repository http://darcs.net/screened:

patch 6bb33dd39be6659341f75cd00d9e71f606318ed4
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Jul  6 09:34:39 CEST 2023
  * make --boring mutually exclusive with --look-for-adds if both are supported

  This means that --boring now implies --look-for-adds i.e. you no longer have
  to list both options for --boring to have any effect. This better mirrors
  how these options are treated internally and IMO removes a wart in the UI.
  Note that the add command is not affected by this.

patch 81bd303661a17b0dda461a5249b8109170ddcc02
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Jul  7 09:03:57 CEST 2023
  * distinguish between option errors and warnings

  The goal here is to strike a balance between being too restrictive (which
  impairs forward compatibility) and too lax (causing ambiguous behavior). For
  instance, an unrecognized option or an extra argument where none is expected
  can be safely ignored in default files, which is good in case we decide to
  add the option or argument later. OTOH, if we allow conflicting options we
  have to make an arbitrary choice which one wins, so we want to be more
  strict here; neither do we want want to allow an option that is missing a
  required argument.
msg23648 (view) Author: ganesh Date: 2023-07-30.12:18:39
I think it's a reasonable change. I might tweak the help strings a bit:

>+    "look for (non-boring) files that could be added"

I wouldn't mention non-boring here, I think it's implicit in the concept
of an ignore/boring file that it will be respected.

> +    "look (even) for boring files"

I think this should mention "could be added", e.g.

"look for any file that could be added, even boring files"
msg23649 (view) Author: bfrk Date: 2023-07-30.14:50:01
Good suggestions. Will follow-up and screen.
msg23650 (view) Author: bfrk Date: 2023-07-30.14:54:23
1 patch for repository http://darcs.net/screened:

patch 315083104ebb40606322f6642e237186f81759c5
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Jul 30 16:47:06 CEST 2023
  * improve help for --look-for-adds/--boring
msg23651 (view) Author: bfrk Date: 2023-07-31.08:32:02
Might as well add one more closely related patch here.

1 patch for repository http://darcs.net/screened:

patch be0274acd1fbb4f604d4645bd4d9370afe324d04
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Jul  7 09:10:02 CEST 2023
  * support short options in defaults files

  So you can say e.g. 'whatsnew -l' in a defaults file. This makes it more or
  less necessary to display options in error and warning messages in full i.e.
  with leading dashes, so we make this change, too. Note that leaving out the
  two dashes for a long option remains allowed in a defaults file, but for
  short options the leading dash is mandatory.
msg23734 (view) Author: ganesh Date: 2024-02-18.14:57:56
all ok (I didn't look at the last one closely)
Date User Action Args
2023-07-30 09:42:51bfrkcreate
2023-07-30 12:18:41ganeshsetmessages: + msg23648
2023-07-30 14:50:02bfrksetmessages: + msg23649
2023-07-30 14:54:24bfrksetfiles: + patch-preview.txt, improve-help-for-__look_for_adds___boring.dpatch
messages: + msg23650
2023-07-30 14:56:28bfrksetstatus: needs-screening -> needs-review
2023-07-31 08:32:03bfrksetfiles: + patch-preview.txt, support-short-options-in-defaults-files.dpatch
messages: + msg23651
2024-02-18 14:57:56ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg23734
2024-02-18 15:47:43ganeshsetstatus: accepted-pending-tests -> accepted