Patch 2344 boring: fix dist-newstyle ignoring on ma... (and 2 more)

Title boring: fix dist-newstyle ignoring on ma... (and 2 more)
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To

Created on 2023-08-06.21:21:48 by ganesh, last changed 2023-08-19.19:28:12 by bfrk.

File name Status Uploaded Type Edit Remove
boring_-fix-dist_newstyle-ignoring-on-mac_-drop-old-cabal_dev-rule.dpatch ganesh, 2023-08-06.21:21:46 application/x-darcs-patch
patch-preview.txt ganesh, 2023-08-06.21:21:46 text/x-darcs-patch
See mailing list archives for discussion on individual patches.
msg23657 (view) Author: ganesh Date: 2023-08-06.21:21:46
submitting (and screening) on behalf of sm

3 patches for repository darcs-unstable@darcs.net:/opt/darcs/screened:

patch 63b37f6bfa64682382ec76231378042f429a91c0
Author: Simon Michael <simon@joyful.com>
Date:   Sun Aug  6 11:53:11 BST 2023
  * boring: fix dist-newstyle ignoring on mac; drop old cabal-dev rule

patch aa7709e643fe79dac2c2206ca759d1411d6385d1
Author: Simon Michael <simon@joyful.com>
Date:   Sun Aug  6 11:55:07 BST 2023
  * boring: .vscode

patch 2007918cc15bc8e4b0eb25f098b106aa096ff601
Author: Simon Michael <simon@joyful.com>
Date:   Sun Aug  6 11:33:32 BST 2023
  * stack.yaml: bump to lts 21, ghc 9.4
msg23660 (view) Author: ganesh Date: 2023-08-06.21:33:55
These all look fine. We might want to actually add real
content in .vscode at some point, but for now ignoring it is ok.

It also seems like a minor bug that the boringfile isn't being
interpreted the same on all platforms; the dist-newstyle directory
itself was being ignored on Linux but was showing up with
--look-for-adds on Mac and Windows. But I don't feel like digging into
that right now so I'm just leaving this note.
msg23665 (view) Author: bfrk Date: 2023-08-07.11:32:02
> * boring: fix dist-newstyle ignoring on mac; drop old cabal-dev rule
> -^(cabal-dev|dist)[^/]*/

I see no reason why this should not work on Mac. We use Darcs.Util.Regex 
which is based on Text.Regex.TDFA which (IIRC) is a pure Haskell 
implementation. I added a small test script to test this and it works in the 
CI (macOS-13, ghc-8.4.4 and ghc-9.4.5).
msg23666 (view) Author: ganesh Date: 2023-08-07.12:33:20
I definitely observed a difference on the darcs repo between Linux 
(nothing new) and Windows (dist-newstyle directory was new). I'll look at 
turning it into a test script, though right now the build isn't working 
for me on Windows.
msg23669 (view) Author: ganesh Date: 2023-08-10.09:49:04
> -^(cabal-dev|dist)[^/]*/

After some investigation I realised that there was a problem in 2.16
but that it's already fixed in HEAD. I haven't tracked down what
exactly fixed it.

Even though the problem is already fixed I think this making the
change to .boring for now is a small quality of life fix for
people developing right now so we might as well leave it.
msg23671 (view) Author: bfrk Date: 2023-08-11.07:37:06
Yes, perfectly fine.
Date User Action Args
2023-08-06 21:21:48ganeshcreate
2023-08-06 21:26:08ganeshsetstatus: needs-screening -> needs-review
2023-08-06 21:33:56ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg23660
2023-08-07 11:32:03bfrksetmessages: + msg23665
2023-08-07 12:33:21ganeshsetmessages: + msg23666
2023-08-10 09:49:05ganeshsetmessages: + msg23669
2023-08-11 07:37:07bfrksetmessages: + msg23671
2023-08-19 19:28:12bfrksetstatus: accepted-pending-tests -> accepted