Patch 2368 resolve issue2716: calculate bundle name... (and 3 more)

Title resolve issue2716: calculate bundle name... (and 3 more)
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To

Created on 2024-02-25.13:24:09 by ganesh, last changed 2024-02-25.17:22:14 by ganesh.

File name Status Uploaded Type Edit Remove
patch-preview.txt ganesh, 2024-02-25.13:24:08 text/x-darcs-patch
resolve-issue2716_-calculate-bundle-names-lazily.dpatch ganesh, 2024-02-25.13:24:08 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
msg23766 (view) Author: ganesh Date: 2024-02-25.13:24:08
I plan to self-accept these reasonably soon in order to
release 2.18

4 patches for repository darcs-unstable@darcs.net:/opt/darcs/screened:

patch 96e3c708e90aeff54ed56223b93138f156a3c08e
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Feb 25 11:36:55 GMT 2024
  * resolve issue2716: calculate bundle names lazily

  Naming a patch bundle after a patch can fail if the patch
  name contains characters that aren't representable in the
  current filesystem encoding.

  Without this fix, it's not even possible to override the
  bundle name with -o, as the default name is calculated

patch ccc73545614495d8673935db361e3cc748bffc27
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Feb 25 11:50:38 GMT 2024
  * correct comment about how patch filenames are made

  isAlpha can include non-ASCII characters

  Changing the implementation to match the comment would
  have been an alternative fix for issue2716, but these
  days having an ASCII-only encoding should be pretty
  rare so it seems better not to make patch names uglier.

patch d003343656bb432ff4a83ab32c49b40aeeec072a
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Feb 25 12:56:40 GMT 2024
  * helpful error message when naming patch file fails

patch 0355d7fc0834ba604ff9841cd38aef2c51ef1a03
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Feb 25 13:02:59 GMT 2024
  * remove workaround - directory 1.3.8 should work fine now
Date User Action Args
2024-02-25 13:24:09ganeshcreate
2024-02-25 13:29:26ganeshsetstatus: needs-screening -> needs-review
2024-02-25 16:52:31ganeshsetstatus: needs-review -> accepted-pending-tests
2024-02-25 17:22:14ganeshsetstatus: accepted-pending-tests -> accepted