darcs

Patch 237 Accept issue1837: inconsistent repo upon darcs get --p...

Title Accept issue1837: inconsistent repo upon darcs get --p...
Superseder Nosy List darcs-users, kowey, mornfall
Related Issues
Status accepted Assigned To
Milestone

Created on 2010-05-07.13:58:18 by kowey, last changed 2011-05-10.19:37:26 by darcswatch.

Files
File name Status Uploaded Type Edit Remove
accept-issue1837_-inconsistent-repo-upon-darcs-get-__partial_.dpatch kowey, 2010-05-07.13:58:17 text/x-darcs-patch
accept-issue1837_-inconsistent-repo-upon-darcs-get-__partial_.dpatch kowey, 2010-05-07.16:05:44 text/x-darcs-patch
unnamed kowey, 2010-05-07.13:58:17
unnamed kowey, 2010-05-07.16:05:44
See mailing list archives for discussion on individual patches.
Messages
msg10997 (view) Author: kowey Date: 2010-05-07.13:58:17
1 patch for repository http://darcs.net/releases/branch-2.4:

The good news: this fails in the expected way.

The bad news: Petr's patch makes it only fail in a different way:
  tests-old-fashioned-inventory.dir/S/_darcs/patches/20090902082037-ab4d8-4510f343483b1381e003227c76d4a1e6bb80d0c9.gz: openBinaryFile: does not exist (No such file or directory)

NB on branch-2.4, not just on HEAD

Ideas?

Fri May  7 12:31:53 BST 2010  Eric Kow <kowey@darcs.net>
  * Accept issue1837: inconsistent repo upon darcs get --partial.
Attachments
msg11000 (view) Author: mornfall Date: 2010-05-07.15:35:51
Hi,

Eric Kow <bugs@darcs.net> writes:
> The bad news: Petr's patch makes it only fail in a different way:

>   tests-old-fashioned-inventory.dir/S/_darcs/patches/20090902082037-ab4d8-4510f343483b1381e003227c76d4a1e6bb80d0c9.gz: openBinaryFile: does not exist (No such file or directory)
>
> NB on branch-2.4, not just on HEAD
>
> Ideas?
Yes, I just figured this out. The problem is that you are running darcs
check in a partial repo (get --old-fashioned --partial). Which does not
work for a while -- since the curtailing of checkpoint support. You need
to skip that darcs check on old-fashioned.

Yours,
   Petr.
msg11002 (view) Author: kowey Date: 2010-05-07.16:05:44
5 patches for repository http://darcs.net/releases/branch-2.4:

This just includes Petr's fixes and observations about the failing test.
I'll push this and his other patch as soon as I complete a small patch
tracker upgrade (making the darcswatch notifications dissapear from
darcs-users)

Fri May  7 16:51:47 BST 2010  Eric Kow <kowey@darcs.net>
  * Accept issue1837: inconsistent repo upon darcs get --partial.

Sun Jan 10 20:18:36 GMT 2010  David Markvica <david@blueshellturtle.com>
  * remove the hardcoded string "_darcs" in some places and replace it with the global darcsdir

Thu May  6 16:15:24 BST 2010  Petr Rockai <me@mornfall.net>
  * In replacePristine, cope also with Trees that have no hashes in them.

Thu May  6 16:19:43 BST 2010  Petr Rockai <me@mornfall.net>
  * Resolve issue1837: Add readWorking and use it in pristineFromWorking.

Fri May  7 16:56:57 BST 2010  Eric Kow <kowey@darcs.net>
  * Mark issue1837 test as passing.
Attachments
msg11017 (view) Author: kowey Date: 2010-05-07.18:30:27
This isn't tracked by darcswatch because it's to the 2.4 branch.
msg14211 (view) Author: darcswatch Date: 2011-05-10.19:37:26
This patch bundle (with 6 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-fabcf77f4d2910a1e87d6d4ed099c8676dbb55ab
History
Date User Action Args
2010-05-07 13:58:18koweycreate
2010-05-07 15:35:51mornfallsetnosy: + mornfall
messages: + msg11000
2010-05-07 16:05:44koweysetfiles: + accept-issue1837_-inconsistent-repo-upon-darcs-get-__partial_.dpatch, unnamed
messages: + msg11002
2010-05-07 18:30:27koweysetstatus: needs-review -> accepted
messages: + msg11017
2011-05-10 19:37:26darcswatchsetmessages: + msg14211