Patch 2383 two optimizations in remove command

Title two optimizations in remove command
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To

Created on 2024-05-10.07:35:02 by bfrk, last changed 2024-05-11.20:36:45 by ganesh.

File name Status Uploaded Type Edit Remove
patch-preview.txt bfrk, 2024-05-10.07:35:01 text/x-darcs-patch
two-optimizations-in-remove-command.dpatch bfrk, 2024-05-10.07:35:01 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
msg23795 (view) Author: bfrk Date: 2024-05-10.07:35:01
1 patch for repository http://darcs.net/screened:

patch cfce007b32b97a1e11ca67e243c7edeba98578b8
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri May 10 09:18:22 CEST 2024
  * two optimizations in remove command

  Frst, avoid duplicate call to readPristineAndPending by passing the pristine
  tree to makeRemovePatch. Also, use a path filter before expanding the tree,
  to avoid expansion of irrelevant parts of the tree.
msg23799 (view) Author: bfrk Date: 2024-05-10.13:33:30
In my tests this makes recursive remove slightly (about 15~20%) faster if you have a large source tree and remove only a small subtree.
msg23809 (view) Author: ganesh Date: 2024-05-11.20:09:35
looks good
Date User Action Args
2024-05-10 07:35:02bfrkcreate
2024-05-10 13:33:31bfrksetmessages: + msg23799
2024-05-10 13:34:24bfrksetstatus: needs-screening -> needs-review
2024-05-11 20:09:36ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg23809
2024-05-11 20:36:45ganeshsetstatus: accepted-pending-tests -> accepted