Patch 2395 resolve issue2721 by excluding certain versions of dir...

Title resolve issue2721 by excluding certain versions of dir...
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To

Created on 2024-05-20.07:40:33 by bfrk, last changed 2024-05-24.15:02:27 by bfrk.

File name Status Uploaded Type Edit Remove
downgrade-stack_yaml-to-use-lts_21_25.dpatch bfrk, 2024-05-20.09:24:58 application/x-darcs-patch
patch-preview.txt bfrk, 2024-05-20.07:40:33 text/x-darcs-patch
patch-preview.txt bfrk, 2024-05-20.09:24:58 text/x-darcs-patch
resolve-issue2721-by-excluding-certain-versions-of-directory-package.dpatch bfrk, 2024-05-20.07:40:33 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
msg23877 (view) Author: bfrk Date: 2024-05-20.07:40:33
I am not screening this one quite yet. Let's the final decision between this
one and patch2392 when directory- appears on hackage.

1 patch for repository https://darcs.net/screened:

patch 48b4d37e2d3ae4773260f7c7afd823bd1fa78024
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon May 20 08:28:04 CEST 2024
  * resolve issue2721 by excluding certain versions of directory package

  Versions 1.3.8 up to of the directory package have a bug in their
  implementation of copyFile on Windows.
msg23878 (view) Author: bfrk Date: 2024-05-20.07:46:57
Apparently it has already appeared on hackage. And it looks as if it 
builds against with all our supported ghc versions. So we could 
even simplify the constraint to just >= && < 1.4. I am not sure 
if this is wise though.
msg23880 (view) Author: ganesh Date: 2024-05-20.08:34:30
I'm also not sure it's wise, directory is a "boot" package so I think
there are scenarios where it could cause trouble. Anyway, we could
consider that in a separate patch, your current approach is a more
minimal fix.

I'm in favour of this rather than patch2392, as I'd hope the whole
ecosystem will pick up the directory fix asap.
msg23883 (view) Author: bfrk Date: 2024-05-20.09:06:02
Building with stack now requires a few more extra-deps, at least with the 
latest lts (or with the latest nightly):
- directory-
- Cabal-
- Cabal-syntax-
- haskeline-
- process-
in addition to the three we already need.

The alternative is to downgrade (for the time being) to lts-21.25 (the 
latest that uses ghc-9.4) and change the conditional (introduced to solve 
the tls issue) in darcs.cabal from

    if impl(ghc >= 8.8)


    if impl(ghc >= 9.6)

This works with just two extra-deps:

resolver: lts-21.25

- .

- strict-identity-
- safe-0.3.21
msg23884 (view) Author: bfrk Date: 2024-05-20.09:24:58
1 patch for repository https://darcs.net/screened:

patch 0b6de928211f1a23ea88b38bcc9127f0e74c5af3
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon May 20 11:06:37 CEST 2024
  * downgrade stack.yaml to use lts-21.25

  Otherwise we would have to add quite a number of extra-deps, even with
  nightly-2024-05-20. This also changes the conditional for depending on
  crypton-connection-0.4.0 in the cabal file to ghc >= 9.6.
msg23885 (view) Author: bfrk Date: 2024-05-20.09:47:49
CI says this works well
msg23888 (view) Author: bfrk Date: 2024-05-21.07:56:07
Screening this now (including the follow-up change in stack.yaml)
msg23892 (view) Author: ganesh Date: 2024-05-22.11:51:24
Looks good
Date User Action Args
2024-05-20 07:40:33bfrkcreate
2024-05-20 07:46:57bfrksetmessages: + msg23878
2024-05-20 08:34:30ganeshsetmessages: + msg23880
2024-05-20 09:06:02bfrksetmessages: + msg23883
2024-05-20 09:24:58bfrksetfiles: + patch-preview.txt, downgrade-stack_yaml-to-use-lts_21_25.dpatch
messages: + msg23884
2024-05-20 09:47:49bfrksetmessages: + msg23885
2024-05-21 07:56:08bfrksetstatus: needs-screening -> needs-review
messages: + msg23888
2024-05-22 11:51:24ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg23892
2024-05-24 15:02:27bfrksetstatus: accepted-pending-tests -> accepted