1 patch for repository darcs.net:darcs:

The reason for the ugly "note" in the cabal file is a reminder to
future us to remove the workaround when cabal has a proper fix.

This patch is pretty minor both in terms of what it changes and how
important it is.  I think it could be "fast tracked", but it's also no
big deal if it doesn't get accepted.

What it it does:  Gets rid of that pesky warning for unused do
bindings on 6.12.  The line in the cabal file should have done it, but
cabal has a bug (at least my cabal 1.8.0.2), that means ghc was still
warning obessively.

Thanks,
Jason

Fri May  7 22:07:21 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * work around cabal flag composition bug
  There is a bug with the way cabal combines flags of different nesting
  levels in the .cabal file.  See ticket 684 for details:
  http://hackage.haskell.org/trac/hackage/ticket/684

Attachments

• unnamed
• work-around-cabal-flag-composition-bug.dpatch

On Sat, May 08, 2010 at 05:13:12 +0000, Jason Dagit wrote:
> This patch is pretty minor both in terms of what it changes and how
> important it is.  I think it could be "fast tracked", but it's also no
> big deal if it doesn't get accepted.

Speaking of fast-tracking, I keep forgetting what we decided, so I
went to
  http://wiki.darcs.net/Development/Policy
which sent me to
  http://wiki.darcs.net/Development/PatchReview
which told me that we can just push our build system patches at will
if we don't think they really need review.

> What it it does:  Gets rid of that pesky warning for unused do
> bindings on 6.12.  The line in the cabal file should have done it, but
> cabal has a bug (at least my cabal 1.8.0.2), that means ghc was still
> warning obessively.

OK, applied (pending tests...)

work around cabal flag composition bug
--------------------------------------
>    -- We need optimizations, regardless of what Hackage says
> -  ghc-options:      -Wall -O2 -funbox-strict-fields -fwarn-tabs
> +  -- Note: "if true" works around a cabal bug with order of flag composition
> +  if true
> +    ghc-options:      -Wall -O2 -funbox-strict-fields -fwarn-tabs

etc...

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-05d2fc68addd5f6914962acba96806fbc5c154c6

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-05d2fc68addd5f6914962acba96806fbc5c154c6