Patch 2419 accept issue1241: rollback with file beyond tag

Title accept issue1241: rollback with file beyond tag
Superseder Nosy List bfrk
Related Issues
Status needs-review Assigned To

Created on 2024-06-23.15:15:21 by bfrk, last changed 2024-06-29.11:02:36 by bfrk.

File name Status Uploaded Type Edit Remove
accept-issue1241_-rollback-with-file-beyond-tag.dpatch bfrk, 2024-06-23.15:15:20 application/x-darcs-patch
patch-preview.txt bfrk, 2024-06-23.15:15:20 text/x-darcs-patch
See mailing list archives for discussion on individual patches.
msg24044 (view) Author: bfrk Date: 2024-06-23.15:15:20
I have stumbled over this inconsistency every now and then.

The following remark does not explain the difference in behavior for this
particular problem, it merely provides context.

File path arguments and --matches "touch <file path>" are implemented in a
completely different way and can have different effects. The former is more
powerful and more useful because it accumulates the effect of 'move' changes
during traversal of the patches (going backwards from the head). A "touch
<file path>" matcher only looks at the patch itself without considering the

It would be nice if we could somehow fix "touch" matchers to have the same
semantics as file path arguments. One idea would be to use the patch index,
which does keep track of 'move' changes i.e. file identities. This would be
a challenging refactor that could permeate all of the patch matching and
patch selection code. The upside is that it would get us rid of the ugly and
unprincipled code that currently implements file path argument matching.

1 patch for repository https://darcs.net/screened:

patch c6c78d6402188570489f139342f3d352d2bab871
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Jun 23 09:57:09 CEST 2024
  * accept issue1241: rollback with file beyond tag
Date User Action Args
2024-06-23 15:15:21bfrkcreate
2024-06-29 11:02:36bfrksetstatus: needs-screening -> needs-review