darcs

Patch 2437 unbundle the shelly dependency (and 3 more)

Title unbundle the shelly dependency (and 3 more)
Superseder Nosy List bfrk
Related Issues
Status accepted-pending-tests Assigned To
Milestone

Created on 2024-12-17.16:03:11 by bfrk, last changed 2025-01-02.14:16:17 by bfrk.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bfrk, 2024-12-17.16:03:08 text/x-darcs-patch
unbundle-the-shelly-dependency.dpatch bfrk, 2024-12-17.16:03:08 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg24129 (view) Author: bfrk Date: 2024-12-17.16:03:08
I thought I would give the latest version of shelly a try, after I noticed
that they removed their dependency on system-filepath and system-fileio some
time ago. Turns out that it now plays well with our test suite, after a few
tweaks.

No longer bundling our antique version of shelly greatly reduces the number
of dependencies for darcs-test.

4 patches for repository https://darcs.net/screened:

patch 38cec59533f2356c74160d5ef94a25cf5f8be39c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Dec  2 16:50:19 CET 2024
  * unbundle the shelly dependency

patch e3f9d11efcec630a4b74f02effce2993d3c809cd
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Dec 16 18:59:48 CET 2024
  * tests/printer.sh: simplify unsetting of env vars

patch 4d8de821458b45859e7101be7076c641027150cc
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Dec 16 19:02:40 CET 2024
  * tests/latin9-input.sh: simplify creation of interaction_script.txt

patch de59a4b922330b47d2e35551ca8718ab6e9cb49a
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Dec  9 19:37:20 CET 2024
  * harness: do not setenv, instead make sure all test scripts source ./lib
Attachments
msg24140 (view) Author: ganesh Date: 2024-12-29.23:07:00
Nice simplification!

>  * harness: do not setenv, instead make sure all test scripts source 
./lib

Out of interest, why did this mean changing some "darcs whatsnew" calls 
to "not darcs whatsnew"?
msg24141 (view) Author: bfrk Date: 2025-01-02.14:16:14
> Out of interest, why did this mean changing some "darcs whatsnew" 
> calls to "not darcs whatsnew"?

That's a very good question.

Clearly "no changes" is the expected state in these cases and that should mean it exits with failure.
It is a mystery to me why the tests previously succeeded without the "not".
History
Date User Action Args
2024-12-17 16:03:11bfrkcreate
2024-12-17 16:06:25bfrksetstatus: needs-screening -> needs-review
2024-12-29 23:07:02ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg24140
2025-01-02 14:16:17bfrksetmessages: + msg24141