Eric,

you were right about using FilePath.Posix. Turns out my previous fix for the
windows URL bug was inadequate, this is hopefully better. Please push when you
can.

Thanks,
   Petr.

1 patch for repository darcs-unstable@darcs.net:darcs:

Tue May 11 21:01:38 CEST 2010  Petr Rockai <me@mornfall.net>
  * Use System.FilePath.Posix instead of System.FilePath.

Attachments

• unnamed
• use-system_filepath_posix-instead-of-system_filepath_.dpatch

On Tue, May 11, 2010 at 19:05:02 +0000, Petr Ročkai wrote:
> you were right about using FilePath.Posix. Turns out my previous fix for the
> windows URL bug was inadequate, this is hopefully better. Please push when you
> can.


Use System.FilePath.Posix instead of System.FilePath.
-----------------------------------------------------
>  read_inventory_private :: Cache -> String -> String -> IO (Maybe String, [(PatchInfo, String)])
>  read_inventory_private _ d iname = do
> -    i <- skip_pristine `fmap` fetchFilePS (d ++ "/" ++ iname) Uncachable -- /, this is URL
> +    i <- skip_pristine `fmap` fetchFilePS (d </> iname) Uncachable
>      (rest,str) <- case BC.break ((==)'\n') i of

I'm still a bit confused, but I think we talked about this on IRC and
the conclusion was that there were no particular correctness advantages
to this, but this is more idiomatic and what we both thought was a URL
was a either-URL-or-FilePath (boy now that we're finally starting to
pull away from this performance obsession, we can start to think a lot
harder about nailing the correctness stuff...)

Applied!

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-382700b9d33b6977ddb0866b789e626380bab40b

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-382700b9d33b6977ddb0866b789e626380bab40b