Eric Kow <kowey@darcs.net> writes:

> On Sat, Oct 03, 2009 at 18:40:22 +1000, Trent W.Buck wrote:
>> Sat Oct  3 18:21:43 EST 2009  Trent W. Buck <trentbuck@gmail.com>
>>   * Rewrite "darcs diff" help.
>
> I'm not sure what to do with this patch, so I await your command
>
> Rewrite "darcs diff" help.
> --------------------------
>> + "The `darcs diff' command compares two versions of the working tree of\n" ++
>> + "the current repository.  Without options, the pristine (recorded) and\n" ++
>> + "unrecorded working trees are compared.  This is equivalent to, but\n" ++
>> + "slower than, the `darcs whatsnew' command, because `darcs diff' relies\n" ++
>> + "on the external diff(1) utility.  As with `darcs whatsnew', if you\n" ++
>
> Two comments about the equivalence between darcs diff and whatsnew.
>
> 1. darcs whatsnew provides higher-level information (mv foo bar; replace
>    x y; changepref z w)
>
> 2. presumably what makes it slower is not that we are outsourcing to
>    diff (1), but that in order to do so we first have to make two
>    copies of the pristine cache on disk and unapply patches to
>    both of them
>
> Looks good to me otherwise.

Per the above, this should probably go straight into "needs amendment" status.

Attachments

• rewrite-_darcs-diff_-help_.dpatch
• unnamed

I'm submitting a new patch since the elimination of literate haskell
happened in the meantime, and took in account Eric's remark.
Screening it.

1 patch for repository http://darcs.net/screened:

Fri Mar  4 15:20:30 CET 2011  Guillaume Hoffmann <guillaumh@gmail.com>
  * Rewrite darcs diff help
  Based on an initial patch by Trent W. Buck and Eric Kow's input.

Attachments

• rewrite-darcs-diff-help.dpatch
• unnamed
• unnamed

Self-accepted.