darcs

Patch 278 Make the tests for dont-prompt-deps use -i

Title Make the tests for dont-prompt-deps use -i
Superseder Nosy List galbolle, kowey
Related Issues
Status accepted Assigned To
Milestone

Created on 2010-06-11.16:53:56 by galbolle, last changed 2011-05-10.18:06:46 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
make-the-tests-for-dont_prompt_deps-use-_i.dpatch galbolle, 2010-06-11.16:53:56 text/x-darcs-patch
unnamed galbolle, 2010-06-11.16:53:56
See mailing list archives for discussion on individual patches.
Messages
msg11373 (view) Author: galbolle Date: 2010-06-11.16:53:56
1 patch for repository http://darcs.net:

Fri Jun 11 18:31:30 CEST 2010  Florent Becker <florent.becker@ens-lyon.org>
  * Make the tests for dont-prompt-deps use -i
  The old tests tested 'darcs foo --match $matcher --all' instead of
  'darcs foo -match $matcher --dont-prompt' because of dry-run.
Attachments
msg11374 (view) Author: kowey Date: 2010-06-11.17:11:07
Make the tests for dont-prompt-deps use -i
------------------------------------------
> Florent Becker <florent.becker@ens-lyon.org>**20100611163130
>  Ignore-this: 3f24c1e9a24774842f95517ff22e6ad2
>  The old tests tested 'darcs foo --match $matcher --all' instead of
>  'darcs foo -match $matcher --dont-prompt' because of dry-run.
> ] hunk ./tests/pull-dont-prompt-deps.sh 25
>  echo bar2 > b
>  darcs record -Ax -alm bar2
>  cd ../temp2
> -echo y | darcs pull ../temp1 --dont-prompt-for-dependencies -p foo2 --dry-run > toto
> -#on the previous line, we don't get asked about foo1.
> -grep foo toto | wc -l | grep 2
> -#but we send it anyway.
> +echo y | darcs pull ../temp1 -i --dont-prompt-for-dependencies -p foo2 --dry-run > toto
> +#on the previous line, we get asked about foo2, and we take it
> +grep foo2 toto | wc -l | grep 2
> +#we don't get asked about foo1, but we take it anyway, so 
> +grep foo1 toto | wc -l | grep 1
> +#and we don't send bar

I'm not 100% clear on what this is for (was the test just not testing
enough because it was accidentally using --all, as you said?), but it
seems fine.

I'm guessing it may be better to test the wc -l output for string
equality instead of using grep but it doesn't matter much.

To be applied on my next round of pushes.

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
msg11478 (view) Author: kowey Date: 2010-06-18.17:26:29
Another patch that darcswatch seems not to have notice as being applied :-/
msg11511 (view) Author: darcswatch Date: 2010-06-21.18:06:22
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-579af10e385be9028413500e77220d73cac26b5b
msg14107 (view) Author: darcswatch Date: 2011-05-10.18:06:46
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-579af10e385be9028413500e77220d73cac26b5b
History
Date User Action Args
2010-06-11 16:53:56galbollecreate
2010-06-11 16:55:29darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-579af10e385be9028413500e77220d73cac26b5b
2010-06-11 17:11:07koweysetnosy: + kowey
messages: + msg11374
2010-06-18 17:26:29koweysetstatus: needs-review -> accepted
messages: + msg11478
2010-06-21 18:06:22darcswatchsetmessages: + msg11511
2011-05-10 18:06:46darcswatchsetmessages: + msg14107