darcs

Patch 287 Patch for issue 1877

Title Patch for issue 1877
Superseder Nosy List galbolle, kowey
Related Issues
Status accepted Assigned To
Milestone

Created on 2010-06-22.09:27:53 by galbolle, last changed 2011-05-10.21:36:53 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
resolve-issue1877_-make-pull-__dry_run-__xml-terse.dpatch galbolle, 2010-06-22.09:27:53 text/x-darcs-patch
use-shell-negation-properly-in-issue1877-test.dpatch galbolle, 2010-06-22.11:49:58 text/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg11540 (view) Author: galbolle Date: 2010-06-22.09:27:53
Une messagerie gratuite, garantie à vie et des services en plus, ça vous tente ?
Je crée ma boîte mail www.laposte.net
Attachments
msg11541 (view) Author: kowey Date: 2010-06-22.09:46:20
resolve issue1877: make pull --dry-run --xml terse
--------------------------------------------------
> -  when (old_default == repodirs) $
> +  when (old_default == repodirs && not (XMLOutput `elem` opts)) $
>        let pulling = if DryRun `elem` opts then "Would pull" else "Pulling"
>        in  putInfo opts $ text $ pulling++" from "++concatMap formatPath repodirs++"..."
>    (Sealed them, Sealed compl) <- readRepos repository opts repodirs

Hmm, that was easy.  Thanks and sorry for the inefficient delegation!
Applied, with a mv patch on top of it to rename the failing test to a
passing one.

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
msg11545 (view) Author: darcswatch Date: 2010-06-22.10:02:25
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-8ccfc53ab7929b15915452fa4e1f29701497e128
msg11547 (view) Author: galbolle Date: 2010-06-22.11:49:58
Apperently, the test failure was a problem with the test itself…
Attachments
msg11548 (view) Author: kowey Date: 2010-06-22.11:56:04
On Tue, Jun 22, 2010 at 11:49:58 +0000, Florent Becker wrote:
> Apperently, the test failure was a problem with the test itself???
 
I see. Sorry for not reviewing that test properly
Applied, thanks!

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
msg11549 (view) Author: darcswatch Date: 2010-06-22.12:02:06
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-b180ff17689fcacd6c10d1252a767340d265f176
msg14031 (view) Author: darcswatch Date: 2011-05-10.17:15:59
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-b180ff17689fcacd6c10d1252a767340d265f176
msg14366 (view) Author: darcswatch Date: 2011-05-10.21:36:53
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-8ccfc53ab7929b15915452fa4e1f29701497e128
History
Date User Action Args
2010-06-22 09:27:53galbollecreate
2010-06-22 09:28:34darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-8ccfc53ab7929b15915452fa4e1f29701497e128
2010-06-22 09:46:20koweysetnosy: + kowey
messages: + msg11541
2010-06-22 10:02:25darcswatchsetstatus: needs-review -> accepted
messages: + msg11545
2010-06-22 11:49:58galbollesetstatus: accepted -> needs-review
files: + use-shell-negation-properly-in-issue1877-test.dpatch
messages: + msg11547
2010-06-22 11:50:56darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-8ccfc53ab7929b15915452fa4e1f29701497e128 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-b180ff17689fcacd6c10d1252a767340d265f176
2010-06-22 11:56:04koweysetmessages: + msg11548
2010-06-22 12:02:06darcswatchsetstatus: needs-review -> accepted
messages: + msg11549
2011-05-10 17:15:59darcswatchsetmessages: + msg14031
2011-05-10 21:36:53darcswatchsetmessages: + msg14366