The pre-release crusade continues.

1 patch for repository darcs-unstable@darcs.net:darcs:

Mon Jun 28 23:13:55 CEST 2010  Petr Rockai <me@mornfall.net>
  * Resolve issue1825: do not omit important prims in unrecordedChanges w/ files.
  
  This is a rather heavy-handed fix. We stop filtering the pending patch in
  unrecordedChanges -- overall, this is an optimisation, since we can now avoid
  reading the pending patch twice, and in most cases we also avoid filtering that
  part of the patch twice. However, in exchange, whatsnew now has to filter the
  patch (this was not required previously). This may be slightly less efficient
  for diffs with very many changed files: however, it is unlikely to be a
  bottleneck, since computing and even formatting the patches for display is much
  more expensive.

Attachments

• resolve-issue1825_-do-not-omit-important-prims-in-unrecordedchanges-w_-files_.dpatch
• unnamed

May I send this one your way, Ganesh?

This looks fine. The basic change is to the behaviour of 
unrecordedChanges, which now returns a conservative over-approximation 
of the changes relating to the supplied set of files. Specifically, 
extra changes are included from the pending patch.

If the supplied set of files is [] (meaning that all files are
wanted), then there is no over-approximation so call-sites that always
use [] are  unaffected.

Call sites that will feed the result into interactive selection are
also unaffected as that does its own filtering.

The only other call sites are in WhatsNew, which is changed by this
patch to refilter the result, and in Changes, which only uses the 
unrecordedChanges to translate the list of files supplied into the names 
they had before the unrecorded changes.

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-23ef60c8c27453ba8109155ec32ddee87887b5a3

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-23ef60c8c27453ba8109155ec32ddee87887b5a3