Hi,

These patches were needed to make release.sh roll a tarball for darcs 2.5 beta 
1. For the patch including minimal-darcs-2.4.tar.gz, I don't understand why 
that file isn't included in the tarball by the glob in darcs.cabal, but 
apparently it isn't.

Reinier

Attachments

• fixrelease.dpatch

Reinier Lamers <bugs@darcs.net> writes:

> Sun Jul 11 13:40:49 CEST 2010  Reinier Lamers <tux_rocker@reinier.de>
>   * Include minimal-darcs-2.4.tgz in distribution
I don't know about this one... could it be a Cabal bug?

> Sun Jul 11 14:08:54 CEST 2010  Reinier Lamers <tux_rocker@reinier.de>
>   * Don't look for version number in exact-version context dump
>   
>   It's not there because darcs releases are built from a dist tarball, not from
>   a repo.

No, this is a bug in the build process, not in the release script. Of
course darcs --exact-version should mention the release tag. If this is
not the case, something went wrong with release/distributed-context or
such.

Yours,
   Petr.

This patch bundle (with 2 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-f07ce9d917bcdd1dd58abb26a766dec58a318e9b

What is the status of this patch exactly?  I rolled it back on HEAD on 
Petr's request (see msg11715) because I'd pushed it in accidentally.  Do 
we not want it at all, or is it amend-requested?

Eric Kow <bugs@darcs.net> writes:

> Eric Kow <kowey@darcs.net> added the comment:
>
> What is the status of this patch exactly?  I rolled it back on HEAD on 
> Petr's request (see msg11715) because I'd pushed it in accidentally.  Do 
> we not want it at all, or is it amend-requested?
We do not want it at all.

A darcs which does not exhibit issue1888 needs to be on PATH while
building release tarballs. I'd also say that 1888 is release-critical,
but it's not marked even target 2.5.

Yours,
   Petr.

This patch bundle (with 2 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-f07ce9d917bcdd1dd58abb26a766dec58a318e9b