Patch 314: resolve issue1716: allow mail header lines of all whitespace in test - Darcs bug tracker

Title	resolve issue1716: allow mail header lines of all whitespace in test
Superseder		Nosy List	kowey, tux_rocker
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2010-07-22.18:58:40 by tux_rocker, last changed 2011-05-10.19:36:28 by darcswatch. Tracked on DarcsWatch.

Files
File name	Status	Uploaded	Type	Edit	Remove
issue1716.dpatch		tux_rocker, 2010-07-22.18:58:39	text/plain
issue1716.dpatch		tux_rocker, 2010-07-22.19:46:53	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg11829 (view)	Author: tux_rocker	Date: 2010-07-22.18:58:40
Hi all, This fixes issue1716 by adapting the test. Perhaps it's best if it goes into 2.5, because it can't really do much damage and will keep the issue from being reported again. Reinier Attachments issue1716.dpatch
msg11830 (view)	Author: tux_rocker	Date: 2010-07-22.19:46:55
Op donderdag 22 juli 2010 20:58 schreef je: > This fixes issue1716 by adapting the test. Perhaps it's best if it goes into > 2.5, because it can't really do much damage and will keep the issue from being > reported again. And this amended version doesn't include a useless new import. Attachments issue1716.dpatch
msg11838 (view)	Author: kowey	Date: 2010-07-23.11:56:44
On Thu, Jul 22, 2010 at 19:46:55 +0000, Reinier Lamers wrote: > Thu Jul 22 21:18:46 CEST 2010 Reinier Lamers <tux_rocker@reinier.de> > * resolve issue1716: allow mail header lines of all whitespace in test > > Reading RFC822, it seems all-whitespace lines are allowed in the header section > when you've got trailing space that doesn't fit on the line before. That seems like a particularly helpful patch long comment. (but I'll have take your word for it...) Applied, thanks! resolve issue1716: allow mail header lines of all whitespace in test -------------------------------------------------------------------- > - in all (not . B.null . B.filter (not . (`elem` [10, 32, 9]))) headerLines > + in all (not . B.null) headerLines --(not . B.null . B.filter (not . (`elem` [10, 32, 9]))) headerLines Are we keeping the old code around as some sort of documentation? -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> For a faster response, please try +44 (0)1273 64 2905.
msg11842 (view)	Author: darcswatch	Date: 2010-07-23.13:02:18
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-70e969ee8d3d4a6fa08e4e89e5d57d1587e332bb
msg11846 (view)	Author: tux_rocker	Date: 2010-07-23.18:36:54
Hi, Op vrijdag 23 juli 2010 13:57 schreef Eric Kow: > resolve issue1716: allow mail header lines of all whitespace in test > -------------------------------------------------------------------- > > - in all (not . B.null . B.filter (not . (`elem` [10, 32, 9]))) headerLines > > + in all (not . B.null) headerLines --(not . B.null . B.filter (not . (`elem` [10, 32, 9]))) headerLines > > Are we keeping the old code around as some sort of documentation? No. That's another oversight. Feel free to remove it in another patch. Reinier
msg14185 (view)	Author: darcswatch	Date: 2011-05-10.19:36:28
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-70e969ee8d3d4a6fa08e4e89e5d57d1587e332bb

History
Date	User	Action	Args
2010-07-22 18:58:40	tux_rocker	create
2010-07-22 19:00:46	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-0cda15df5a6776d775bbf0a1a7ec17c16a58fbc3
2010-07-22 19:46:55	tux_rocker	set	files: + issue1716.dpatch messages: + msg11830
2010-07-22 19:53:12	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-0cda15df5a6776d775bbf0a1a7ec17c16a58fbc3 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-70e969ee8d3d4a6fa08e4e89e5d57d1587e332bb
2010-07-23 11:56:45	kowey	set	nosy: + kowey messages: + msg11838 title: resolve issue1716: allow mail header lines of all whitespace in test -> resolve issue1716: allow mail header lines of all whitespace in test
2010-07-23 13:02:18	darcswatch	set	status: needs-review -> accepted messages: + msg11842
2010-07-23 18:36:54	tux_rocker	set	messages: + msg11846
2011-05-10 17:16:02	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-70e969ee8d3d4a6fa08e4e89e5d57d1587e332bb -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-0cda15df5a6776d775bbf0a1a7ec17c16a58fbc3
2011-05-10 19:36:28	darcswatch	set	messages: + msg14185