darcs

Patch 315 Add a flag for release-quality builds(-... (and 15 more)

Title Add a flag for release-quality builds(-... (and 15 more)
Superseder Nosy List ganesh, kowey
Related Issues
Status accepted Assigned To
Milestone

Created on 2010-07-23.13:45:45 by kowey, last changed 2011-05-10.22:07:29 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
add-a-flag-for-release_quality-builds-__werror__.dpatch kowey, 2010-07-23.13:45:45 text/x-darcs-patch
fix-deprecation-warning-on-ghc_handle-in-exec-module_.dpatch kowey, 2010-07-26.13:50:30 text/x-darcs-patch
unnamed kowey, 2010-07-23.13:45:45
unnamed kowey, 2010-07-26.13:50:30
See mailing list archives for discussion on individual patches.
Messages
msg11844 (view) Author: kowey Date: 2010-07-23.13:45:45
16 patches for repository http://darcs.net:

Jason pointed out that we weren't doing a good enough job staying on top of
warnings.

One idea might be to have a policy of that warnings should be fixed by the
first release candidate.

This only goes halfway.  I stopped at a Darcs.Repository.HashedRepo
type signature because there may be witnesses involved and I didn't
really want to think about it at the moment :-/

Fri Jul 23 14:18:33 BST 2010  Eric Kow <kowey@darcs.net>
  * Add a flag for release-quality builds (-Werror).
  This should help us to avoid having lots of warnings by making sure we at
  least clean up the code on each darcs release.

Fri Jul 23 14:18:43 BST 2010  Eric Kow <kowey@darcs.net>
  * Remove PatternSignatures as we currently require GHC 6.10 and up.

Fri Jul 23 14:18:47 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix deprecation warning on GHC.Handle in Exec module.
  It looks like it was deprecated in GHC 6.12 along with the
  Unicode-oriented rewrite.

Fri Jul 23 14:20:31 BST 2010  Eric Kow <kowey@darcs.net>
  * Suppress orphan instance warnings in Darcs.Witnesses.Ordered.

Fri Jul 23 14:24:08 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix RemoteDarcs related imports warning in Darcs.Flags and Darcs.RemoteApply.

Fri Jul 23 14:32:39 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix redundant imports in Darcs.Patch.Apply.
  Likely due to setScriptsExecutable refactor.

Fri Jul 23 14:33:51 BST 2010  Eric Kow <kowey@darcs.net>
  * Update GADT syntax in Darcs.Patch.Choices.

Fri Jul 23 14:33:57 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix shadow warning in Darcs.Patch.Choices.

Fri Jul 23 14:35:40 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix redundant imports in Darcs.Patch.Commute.

Fri Jul 23 14:36:11 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix incomplete pattern match in Darcs.Patch.Depends.
  Seems like an explicit bug is better than a incomplete-match crash

Fri Jul 23 14:44:47 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix redundant import warning in Darcs.Patch.Patchy.

Fri Jul 23 14:45:01 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Patch.Prim.

Fri Jul 23 14:45:15 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Repository.DarcsRepo.

Fri Jul 23 14:45:33 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Repository.HashedIO.

Fri Jul 23 14:45:56 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Repository.InternalTypes.

Fri Jul 23 14:46:11 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Repository.State.


___________________________________________________________
This email has been scanned by MessageLabs' Email Security
System on behalf of the University of Brighton.
For more information see http://www.brighton.ac.uk/is/spam/
___________________________________________________________
Attachments
msg11845 (view) Author: ganesh Date: 2010-07-23.13:53:28
Warnings are tricky little buggers, because often one version of GHC
will warn about something that's needed for the previous version of GHC,
or vice versa!

> Fri Jul 23 14:18:43 BST 2010  Eric Kow <kowey@darcs.net>
>   * Remove PatternSignatures as we currently require GHC 6.10 and up.

Do we actually have any other things that break with 6.8? I don't want
to support it explicitly, but going out of our way to break it seems
excessive.

> Fri Jul 23 14:20:31 BST 2010  Eric Kow <kowey@darcs.net>
>   * Suppress orphan instance warnings in Darcs.Witnesses.Ordered.

We shouldn't suppress these unless we're sure we can't fix the orphan.

> Fri Jul 23 14:33:51 BST 2010  Eric Kow <kowey@darcs.net>
>   * Update GADT syntax in Darcs.Patch.Choices.

This will break 6.10, IIRC.

> Fri Jul 23 14:36:11 BST 2010  Eric Kow <kowey@darcs.net>
>   * Fix incomplete pattern match in Darcs.Patch.Depends.
>   Seems like an explicit bug is better than a incomplete-match crash

This is actually a witnesses problem - I think it's commented out
because Petr couldn't fix the witnesses compile error if you uncomment
it. I also tried (briefly) a few weeks ago and failed.

Ganesh

=============================================================================== 
Please access the attached hyperlink for an important electronic communications disclaimer: 
http://www.credit-suisse.com/legal/en/disclaimer_email_ib.html 
===============================================================================
msg11859 (view) Author: kowey Date: 2010-07-25.21:54:26
We should probably ignore the ones you pointed out until the 2.5 release
is out.

But there should be some easy ones in here to cherry pick.
msg11879 (view) Author: kowey Date: 2010-07-26.13:50:30
12 patches for repository http://darcs.net:

This is just the same bundle with the potentially problematic ptaches
cherry-picked out.

I actually have quite a few more of these cleanups in my working director, but
appear to be dithering on grouping them into patches.

Fri Jul 23 14:18:47 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix deprecation warning on GHC.Handle in Exec module.
  It looks like it was deprecated in GHC 6.12 along with the
  Unicode-oriented rewrite.

Fri Jul 23 14:24:08 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix RemoteDarcs related imports warning in Darcs.Flags and Darcs.RemoteApply.

Fri Jul 23 14:32:39 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix redundant imports in Darcs.Patch.Apply.
  Likely due to setScriptsExecutable refactor.

Fri Jul 23 14:33:57 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix shadow warning in Darcs.Patch.Choices.

Fri Jul 23 14:35:40 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix redundant imports in Darcs.Patch.Commute.

Fri Jul 23 14:44:47 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix redundant import warning in Darcs.Patch.Patchy.

Fri Jul 23 14:45:01 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Patch.Prim.

Fri Jul 23 14:45:15 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Repository.DarcsRepo.

Fri Jul 23 14:45:33 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Repository.HashedIO.

Fri Jul 23 14:45:56 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Repository.InternalTypes.

Fri Jul 23 14:46:11 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Repository.State.

Mon Jul 26 14:42:37 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix missing type signature in Darcs.Arguments.


___________________________________________________________
This email has been scanned by MessageLabs' Email Security
System on behalf of the University of Brighton.
For more information see http://www.brighton.ac.uk/is/spam/
___________________________________________________________
Attachments
msg11991 (view) Author: darcswatch Date: 2010-08-06.09:02:26
This patch bundle (with 12 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-71f21da01e649b6c83df19e1af80cd98a071bdae
msg14402 (view) Author: darcswatch Date: 2011-05-10.22:07:29
This patch bundle (with 12 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-71f21da01e649b6c83df19e1af80cd98a071bdae
History
Date User Action Args
2010-07-23 13:45:45koweycreate
2010-07-23 13:46:50darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-2066370ee766d4ddbe92323545673a175b380458
2010-07-23 13:53:28ganeshsetnosy: + ganesh
messages: + msg11845
title: Add a flag for release-quality builds (-... (and 15 more) -> Add a flag for release-quality builds(-... (and 15 more)
2010-07-25 21:54:26koweysetmessages: + msg11859
2010-07-26 13:50:30koweysetfiles: + fix-deprecation-warning-on-ghc_handle-in-exec-module_.dpatch, unnamed
messages: + msg11879
2010-07-26 13:51:32darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-2066370ee766d4ddbe92323545673a175b380458 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-71f21da01e649b6c83df19e1af80cd98a071bdae
2010-08-06 09:02:26darcswatchsetstatus: needs-review -> accepted
messages: + msg11991
2011-05-10 19:06:39darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-71f21da01e649b6c83df19e1af80cd98a071bdae -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-2066370ee766d4ddbe92323545673a175b380458
2011-05-10 22:07:29darcswatchsetmessages: + msg14402