16 patches for repository http://darcs.net:

Jason pointed out that we weren't doing a good enough job staying on top of
warnings.

One idea might be to have a policy of that warnings should be fixed by the
first release candidate.

This only goes halfway.  I stopped at a Darcs.Repository.HashedRepo
type signature because there may be witnesses involved and I didn't
really want to think about it at the moment :-/

Fri Jul 23 14:18:33 BST 2010  Eric Kow <kowey@darcs.net>
  * Add a flag for release-quality builds (-Werror).
  This should help us to avoid having lots of warnings by making sure we at
  least clean up the code on each darcs release.

Fri Jul 23 14:18:43 BST 2010  Eric Kow <kowey@darcs.net>
  * Remove PatternSignatures as we currently require GHC 6.10 and up.

Fri Jul 23 14:18:47 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix deprecation warning on GHC.Handle in Exec module.
  It looks like it was deprecated in GHC 6.12 along with the
  Unicode-oriented rewrite.

Fri Jul 23 14:20:31 BST 2010  Eric Kow <kowey@darcs.net>
  * Suppress orphan instance warnings in Darcs.Witnesses.Ordered.

Fri Jul 23 14:24:08 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix RemoteDarcs related imports warning in Darcs.Flags and Darcs.RemoteApply.

Fri Jul 23 14:32:39 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix redundant imports in Darcs.Patch.Apply.
  Likely due to setScriptsExecutable refactor.

Fri Jul 23 14:33:51 BST 2010  Eric Kow <kowey@darcs.net>
  * Update GADT syntax in Darcs.Patch.Choices.

Fri Jul 23 14:33:57 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix shadow warning in Darcs.Patch.Choices.

Fri Jul 23 14:35:40 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix redundant imports in Darcs.Patch.Commute.

Fri Jul 23 14:36:11 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix incomplete pattern match in Darcs.Patch.Depends.
  Seems like an explicit bug is better than a incomplete-match crash

Fri Jul 23 14:44:47 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix redundant import warning in Darcs.Patch.Patchy.

Fri Jul 23 14:45:01 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Patch.Prim.

Fri Jul 23 14:45:15 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Repository.DarcsRepo.

Fri Jul 23 14:45:33 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Repository.HashedIO.

Fri Jul 23 14:45:56 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Repository.InternalTypes.

Fri Jul 23 14:46:11 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Repository.State.


___________________________________________________________
This email has been scanned by MessageLabs' Email Security
System on behalf of the University of Brighton.
For more information see http://www.brighton.ac.uk/is/spam/
___________________________________________________________

Attachments

• add-a-flag-for-release_quality-builds-__werror__.dpatch
• unnamed

Warnings are tricky little buggers, because often one version of GHC
will warn about something that's needed for the previous version of GHC,
or vice versa!

> Fri Jul 23 14:18:43 BST 2010  Eric Kow <kowey@darcs.net>
>   * Remove PatternSignatures as we currently require GHC 6.10 and up.

Do we actually have any other things that break with 6.8? I don't want
to support it explicitly, but going out of our way to break it seems
excessive.

> Fri Jul 23 14:20:31 BST 2010  Eric Kow <kowey@darcs.net>
>   * Suppress orphan instance warnings in Darcs.Witnesses.Ordered.

We shouldn't suppress these unless we're sure we can't fix the orphan.

> Fri Jul 23 14:33:51 BST 2010  Eric Kow <kowey@darcs.net>
>   * Update GADT syntax in Darcs.Patch.Choices.

This will break 6.10, IIRC.

> Fri Jul 23 14:36:11 BST 2010  Eric Kow <kowey@darcs.net>
>   * Fix incomplete pattern match in Darcs.Patch.Depends.
>   Seems like an explicit bug is better than a incomplete-match crash

This is actually a witnesses problem - I think it's commented out
because Petr couldn't fix the witnesses compile error if you uncomment
it. I also tried (briefly) a few weeks ago and failed.

Ganesh

=============================================================================== 
Please access the attached hyperlink for an important electronic communications disclaimer: 
http://www.credit-suisse.com/legal/en/disclaimer_email_ib.html 
===============================================================================

We should probably ignore the ones you pointed out until the 2.5 release
is out.

But there should be some easy ones in here to cherry pick.

12 patches for repository http://darcs.net:

This is just the same bundle with the potentially problematic ptaches
cherry-picked out.

I actually have quite a few more of these cleanups in my working director, but
appear to be dithering on grouping them into patches.

Fri Jul 23 14:18:47 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix deprecation warning on GHC.Handle in Exec module.
  It looks like it was deprecated in GHC 6.12 along with the
  Unicode-oriented rewrite.

Fri Jul 23 14:24:08 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix RemoteDarcs related imports warning in Darcs.Flags and Darcs.RemoteApply.

Fri Jul 23 14:32:39 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix redundant imports in Darcs.Patch.Apply.
  Likely due to setScriptsExecutable refactor.

Fri Jul 23 14:33:57 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix shadow warning in Darcs.Patch.Choices.

Fri Jul 23 14:35:40 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix redundant imports in Darcs.Patch.Commute.

Fri Jul 23 14:44:47 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix redundant import warning in Darcs.Patch.Patchy.

Fri Jul 23 14:45:01 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Patch.Prim.

Fri Jul 23 14:45:15 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Repository.DarcsRepo.

Fri Jul 23 14:45:33 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Repository.HashedIO.

Fri Jul 23 14:45:56 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Repository.InternalTypes.

Fri Jul 23 14:46:11 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix warnings in Darcs.Repository.State.

Mon Jul 26 14:42:37 BST 2010  Eric Kow <kowey@darcs.net>
  * Fix missing type signature in Darcs.Arguments.


___________________________________________________________
This email has been scanned by MessageLabs' Email Security
System on behalf of the University of Brighton.
For more information see http://www.brighton.ac.uk/is/spam/
___________________________________________________________

Attachments

• fix-deprecation-warning-on-ghc_handle-in-exec-module_.dpatch
• unnamed

This patch bundle (with 12 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-71f21da01e649b6c83df19e1af80cd98a071bdae

This patch bundle (with 12 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-71f21da01e649b6c83df19e1af80cd98a071bdae