Patch 33 Haddock the Darcs.Patch.Commute class a ... (and 1 more)

Title Haddock the Darcs.Patch.Commute class a ... (and 1 more)
Superseder Nosy List dagit, kowey
Related Issues
Status accepted Assigned To dagit

Created on 2009-10-31.21:02:08 by kowey, last changed 2009-11-09.04:09:41 by dagit.

File name Status Uploaded Type Edit Remove
haddock-the-darcs_patch_commute-class-a-little-bit_.dpatch kowey, 2009-10-31.21:02:08 text/x-darcs-patch
unnamed kowey, 2009-10-31.21:02:08 text/plain
unnamed dagit, 2009-11-09.04:08:04 text/html
See mailing list archives for discussion on individual patches.
msg9146 (view) Author: kowey Date: 2009-10-31.21:02:08
[Resending for patch tracker]

Sun Apr 19 12:59:51 BST 2009  Eric Kow <kowey@darcs.net>
  * Haddock the Darcs.Patch.Commute class a little bit.

Sun Oct 11 16:43:06 BST 2009  Eric Kow <kowey@darcs.net>
  * Haddock Darcs.Patch.Non addP and addPs.
msg9172 (view) Author: kowey Date: 2009-11-01.23:47:56
Hi Jason, I'd also like to send this one your way pending round tuits.  This one
can definitely wait till you're less busy.
msg9218 (view) Author: dagit Date: 2009-11-09.04:08:04

+    --   Question: if there is no difference, why do we have two different
> +    --   functions?  Is it just convenience?  Eric 2009-04-19

Not convenience exactly.  More like, conservative refactoring.  David told
me he added it when we started the type witness stuff so that it would make
the transition easier.  It can and should now be removed because the types
will prevent it from being done incorrectly.  Now, having said that.  It
doesn't hurt that much because the types tell you which way the commute is
happening.  But, I'd argue that simpler is better.

Applied, thanks!
msg9219 (view) Author: dagit Date: 2009-11-09.04:09:40
Date User Action Args
2009-10-31 21:02:08koweycreate
2009-11-01 23:47:57koweysetassignedto: dagit
messages: + msg9172
nosy: + dagit
2009-11-09 04:08:17dagitsetfiles: + unnamed
messages: + msg9218
2009-11-09 04:09:41dagitsetstatus: needs-review -> accepted
messages: + msg9219