1 patch for repository http://darcs.net/releases/branch-2.5:

This is basically just work in progress.  Here I was thinking it was going to
be easy.  It still should be; but there are a few little UI subtleties to
account for, so I thought a test would be better.

Note that the setDefaultRepo code seems to be called before any patches are
presented to the user, so the prompt to introduce should be phrased accordingly,
for example:

  putStr . unlines $
    [ "Note: if you want to change the default remote repository to"
    , r, ","
    , "quit now and issue the same command with the --set-default flag."
    ]
 
Incidentally, this is one of those layering/abstraction issues that confuses
me.  The function this would likely appear in is on a lower level
(Darcs.Repository.Prefs) in the sense that it's focused on the actual task of
setting the default repository or not; but by rights, because it's a
lower-level function it shouldn't assume it's going to be called before or
after the action of the command, so it shouldn't really have a right to control
the wording of this notification.  I guess this means the notification needs to
live on some higher level, but still be made into a reusable function.  But
then it still needs to make some sort of low-level decisions.  I think I'm just
confused because it's late.

Tue Aug 10 22:57:50 BST 2010  Eric Kow <kowey@darcs.net>
  * Accept issue1898: set-default notification system.

Attachments

• accept-issue1898_-set_default-notification-system_.dpatch
• unnamed

Hi,

Op woensdag 11 augustus 2010 00:03 schreef Eric Kow:
>   putStr . unlines $
>     [ "Note: if you want to change the default remote repository to"
>     , r, ","
>     , "quit now and issue the same command with the --set-default flag."
>     ]

Are we really going to have darcs output these notes every time you pull 
something? Is that really necessary? If we start outputting a note every time 
the code makes a certain choice, the console output will get very cluttered...

Reinier

Reinier Lamers wrote:
> Reinier Lamers <tux_rocker@reinier.de> added the comment:
> 
> Hi,
> 
> Op woensdag 11 augustus 2010 00:03 schreef Eric Kow:
>>   putStr . unlines $
>>     [ "Note: if you want to change the default remote repository to"
>>     , r, "," , "quit now and issue the same command with the
>>     --set-default flag." ]
> 
> Are we really going to have darcs output these notes every time you
> pull something? Is that really necessary? If we start outputting a
> note every time the code makes a certain choice, the console output
> will get very cluttered...   

IMO we either need this note, or we need to rollback the change. I got
very confused by the behaviour change, and I was actually at the meeting
where we agreed it!

Ganesh

=============================================================================== 
Please access the attached hyperlink for an important electronic communications disclaimer: 
http://www.credit-suisse.com/legal/en/disclaimer_email_ib.html 
===============================================================================