The same patches, now with description.

State of smart server work at the pencils down time.  Implemented repo
identification, File and HTTP dumb protocols and prototype of SmartHTTP one.
Implemented getting Repository datatype out of RepoIO for compability with
older code.  Pull command partly rewritten to use RepoIO.  Currently making a
pull via RepoIO may corrupt a repository.

To serve a repository:
$ mkdir _darcs/cgi
$ cp contrib/serve.pl _darcs/cgi

Make sure _darcs/cgi/serve.pl is executable as cgi script and has access to
the repository.

2 patches for repository http://darcs.net:

Mon Aug 16 21:35:34 EEST 2010  Alexey Levan <exlevan@gmail.com>
  * Add serve.pl to contrib

Mon Aug 16 21:59:30 EEST 2010  Alexey Levan <exlevan@gmail.com>
  * Smart server

Attachments

• add-serve_pl-to-contrib.dpatch
• unnamed

I have amended out the obvious junk, so this is the patch that is going to be
reviewed.

Yours,
   Petr.

2 patches for repository http://darcs.net:

Mon Aug 16 20:35:34 CEST 2010  Alexey Levan <exlevan@gmail.com>
  * Add serve.pl to contrib

Mon Aug 16 20:59:30 CEST 2010  Alexey Levan <exlevan@gmail.com>
  * Smart server

Attachments

• add-serve_pl-to-contrib.dpatch
• unnamed

Hi,

Petr Ročkai <bugs@darcs.net> writes:

> addfile ./contrib/serve.pl
> hunk ./contrib/serve.pl 1
> +#!/usr/bin/perl
> +
> +use warnings;
> +use strict;
> +use CGI::Carp qw(fatalsToBrowser);
> +use File::Spec::Functions qw(rel2abs);
> +use File::Basename;
> +
> +$| = 1;
> +chdir(dirname(rel2abs($0)) . "/../..") or die $!;
> +open(DARCS, "| dist/build/darcs/darcs serve") or die $!;
> +while (<>) {
> +  print DARCS $_;
> +}
Ok, this is a wrapper around darcs serve. I understand this part.

> addfile ./src/Darcs/Commands/Serve.hs
> hunk ./src/Darcs/Commands/Serve.hs 1
> +module Darcs.Commands.Serve ( serve ) where
> +
> +import Control.Applicative ( (<$>) )
> +import Control.Exception ( IOException, try )
> +import Darcs.Arguments ( DarcsFlag, workingRepoDir )
> +import Darcs.Commands ( DarcsCommand(..), nodefaults )
> +import Darcs.Global ( darcsdir )
> +import Darcs.RepoIO ( withRepoIO )
> +import Darcs.Repository ( amInRepository )
> +import Progress ( setProgressMode )
> +
> +serve :: DarcsCommand
> +serve = DarcsCommand
> +  { commandName = "serve"
> +  , commandHelp = ""
> +  , commandDescription = ""
> +  , commandExtraArgs = 0
> +  , commandExtraArgHelp = []
> +  , commandGetArgPossibilities = return []
> +  , commandCommand = serveCmd
> +  , commandPrereq = amInRepository
> +  , commandArgdefaults = nodefaults
> +  , commandAdvancedOptions = []
> +  , commandBasicOptions = [workingRepoDir]
> +  }
> +
> +serveCmd :: [DarcsFlag] -> [String] -> IO ()
> +serveCmd opts _ = do
> +  setProgressMode False
> +  withRepoIO opts "." $ \rio -> do
> +    c <- try getLine
> +    case c of
> +      Left (e :: IOException) -> print404 $ show e
> +      Right x -> print404 $ "darcs serve error: Unknown command " ++ x
> +
> +print404 :: String -> IO ()
> +print404 x = putStr $ unlines
> +  [ "Status: 404 Not Found"
> +  , "Content-Type: text/plain"
> +  , ""
> +  , x
> +  ]

What I don't understand is what is this "darcs serve" supposed to be
doing. Whatever that is and however I look at this code, all I can see
is "error out with 404 no matter what".

How is this ever going to work?

Yours,
   Petr.

(just realized that mail wasn't sent to BTS, sorry for duplicate)

>> +serveCmd :: [DarcsFlag] -> [String] -> IO ()
>> +serveCmd opts _ = do
>> +  setProgressMode False
>> +  withRepoIO opts "." $ \rio -> do
>> +    c <- try getLine
>> +    case c of
>> +      Left (e :: IOException) -> print404 $ show e
>> +      Right x -> print404 $ "darcs serve error: Unknown command " ++ x
>> +
>> +print404 :: String -> IO ()
>> +print404 x = putStr $ unlines
>> +  [ "Status: 404 Not Found"
>> +  , "Content-Type: text/plain"
>> +  , ""
>> +  , x
>> +  ]
>
> What I don't understand is what is this "darcs serve" supposed to be
> doing. Whatever that is and however I look at this code, all I can see
> is "error out with 404 no matter what".
>
> How is this ever going to work?

It's stub for smart server, and is meant to be extended to support
vsrious commands. Currently the only command send to server is "ping",
and I should have added a line to support it.  However, that wouldn't
make a difference as for everyting else smart server should fall back
to old repository interface.

I believe this will have to be future work as a new submission.