Patch 355: Changes.lhs: remove extra (and weird) case - Darcs bug tracker

Title	Changes.lhs: remove extra (and weird) case
Superseder		Nosy List	dagit, kowey
Related Issues
Status	accepted	Assigned To	kowey
Milestone

Created on 2010-08-22.12:38:05 by dagit, last changed 2011-05-10.17:36:03 by darcswatch. Tracked on DarcsWatch.

Files
File name	Status	Uploaded	Type	Edit	Remove
changes_lhs_-remove-extra-_and-weird_-case.dpatch		dagit, 2010-08-22.12:38:05	text/x-darcs-patch
unnamed		dagit, 2010-08-22.12:38:05

See mailing list archives for discussion on individual patches.

Messages
msg12252 (view)	Author: dagit	Date: 2010-08-22.12:38:05
The case in question was modified last in this patch: Sat Aug 23 11:09:47 PDT 2008 David Roundy <droundy@darcs.net> * eliminate fix_flag. Judging by the contents of that patch, that case was originally handling an empty name, but the current version matches any name and is thus buggy. By the time we get here the head of [DarcsFlag] is never Context so no users have been able to stumble on it (yet). Also, our test suite can catch it, but let's do one better and just remove the unnecessary case. Thanks, Jason 1 patch for repository http://darcs.net: Sun Aug 22 05:26:59 PDT 2010 Jason Dagit <dagit@codersbase.com> * Changes.lhs: remove extra (and weird) case Attachments changes_lhs_-remove-extra-_and-weird_-case.dpatch unnamed
msg12328 (view)	Author: dagit	Date: 2010-08-27.05:10:21
Eric, This should only take a second to review. I promise it passes the tests. Jason
msg12363 (view)	Author: kowey	Date: 2010-08-28.21:09:27
Digging deeper into this, the extra case was there from the very beginning, when David introduced the context flag "add --context option to changes and get." And just returning () doesn't sound right anyway, so applied thanks!
msg12364 (view)	Author: darcswatch	Date: 2010-08-28.21:47:00
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-f27adafb5b1bc739ca1ced4c8a624acd6b512d6c
msg14061 (view)	Author: darcswatch	Date: 2011-05-10.17:36:03
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-f27adafb5b1bc739ca1ced4c8a624acd6b512d6c

History
Date	User	Action	Args
2010-08-22 12:38:05	dagit	create
2010-08-22 12:42:58	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-f27adafb5b1bc739ca1ced4c8a624acd6b512d6c
2010-08-27 05:10:21	dagit	set	assignedto: kowey messages: + msg12328 nosy: + kowey
2010-08-28 21:09:27	kowey	set	messages: + msg12363
2010-08-28 21:47:00	darcswatch	set	status: needs-review -> accepted messages: + msg12364
2011-05-10 17:36:03	darcswatch	set	messages: + msg14061