darcs

Patch 504 remove W nonsense in Darcs.Test.Patch.Unit

Title remove W nonsense in Darcs.Test.Patch.Unit
Superseder Nosy List galbolle, ganesh
Related Issues
Status rejected Assigned To
Milestone

Created on 2010-12-15.07:29:20 by galbolle, last changed 2011-05-10.17:16:00 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
remove-w-nonsense-in-darcs_test_patch_unit.dpatch galbolle, 2010-12-15.07:29:20 text/x-darcs-patch
unnamed galbolle, 2010-12-15.07:29:20
See mailing list archives for discussion on individual patches.
Messages
msg13328 (view) Author: galbolle Date: 2010-12-15.07:29:20
Not self-screening this one; can someone check that it makes sense. The module
seems to compile after just axing the pseudo-witnesses, so I guess it's ok.

1 patch for repository http://darcs.net/screened:


Fri Dec 10 17:02:04 CET 2010  Florent Becker <florent.becker@ens-lyon.org>
  * remove W nonsense in Darcs.Test.Patch.Unit
Attachments
msg13343 (view) Author: ganesh Date: 2010-12-15.22:09:20
GAH! Somehow we lost -DGADT_WITNESSES in the test harness build.

If you put this back, then things don't compile at all with this patch.

I'll figure out how we lost the flag and put it back.
msg13344 (view) Author: ganesh Date: 2010-12-15.22:12:22
PS I know it's horrible, but I couldn't think of a better idea :-(
History
Date User Action Args
2010-12-15 07:29:20galbollecreate
2010-12-15 22:09:20ganeshsetstatus: needs-review -> rejected
nosy: + ganesh
messages: + msg13343
2010-12-15 22:12:22ganeshsetmessages: + msg13344
2010-12-16 17:08:11darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-152be52594cca7d57bf1bdd2f286ec874be9b05c
2011-05-10 17:16:00darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-152be52594cca7d57bf1bdd2f286ec874be9b05c -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-152be52594cca7d57bf1bdd2f286ec874be9b05c