darcs

Patch 590 Friendlier exceptions when a file does n... (and 1 more)

Title Friendlier exceptions when a file does n... (and 1 more)
Superseder Nosy List kowey
Related Issues
Status accepted Assigned To kowey
Milestone

Created on 2011-04-07.17:28:27 by kowey, last changed 2011-10-12.06:23:47 by ganesh.

Files
File name Status Uploaded Type Edit Remove
friendlier-exceptions-when-a-file-does-not-exist_.dpatch kowey, 2011-04-07.17:28:24 application/x-darcs-patch
unnamed kowey, 2011-04-07.17:28:23 text/x-darcs-patch
unnamed kowey, 2011-04-07.17:28:24
See mailing list archives for discussion on individual patches.
Messages
msg13916 (view) Author: kowey Date: 2011-04-07.17:28:24
A bit of procrasti-hacking (I wish I did procrasti-reviewing instead of
procrasti-hacking, but the latter is easier since I keep working on these
ProbablyEasy UI-level things)

2 patches for repository http://darcs.net/screened:

The first patch fixes the case of darcs get /tmp/blahblahblah

Before:
  $ darcs get /tmp/blahblahblah
  darcs failed:  Not a repository: /tmp/blahblahblah (/tmp/blahblahblah/_darcs/inventory: openBinaryFile: does not exist (No such file or directory))
After:
  darcs failed:  Not a repository: /tmp/blahblahblah (/tmp/blahblahblah/_darcs/inventory does not exist)

As for the second patch,

Before:
  $ darcs add apt/apt.conf.d/10apt-listbugs.distrib, you now get
  darcs: apt/apt.conf.d/10apt-listbugs.distrib: getSymbolicLinkStatus: does not exist (No such file or directory)

After:
  File apt does not exist!
  File apt/apt.conf.d does not exist!
  File apt/apt.conf.d/10apt-listbugs.distrib does not exist!

This output is friendlier, but it's also a bit stupid (hence me not screening
the patch). I suppose what we should do is collect the names of files, turn it
into tree and only emit the error message on leaves of the tree.

Thu Apr  7 15:28:47 BST 2011  Eric Kow <kowey@darcs.net>
  * Friendlier exceptions when a file does not exist.

Thu Apr  7 18:10:49 BST 2011  Eric Kow <kowey@darcs.net>
  * Resolve issue1804: friendlier message when adding missing files.
  
  Instead of
    darcs: foo: getSymbolicLinkStatus: does not exist (No such file or directory)
  We now have
    File foo does not exist!


___________________________________________________________
This email has been scanned by MessageLabs' Email Security
System on behalf of the University of Brighton.
For more information see http://www.brighton.ac.uk/is/spam/
___________________________________________________________
Attachments
msg14024 (view) Author: galbolle Date: 2011-05-10.12:30:50
This seems to break the following tests as they don't grep for the right
string anyomre, but otherwise seems ok.

Broken tests:
issue1951-add-outside-repo.sh
issue1162_add_nonexistent_slash.sh
msg14507 (view) Author: ganesh Date: 2011-06-08.19:45:44
Looks ok; the test failures are fixed by patch609. So don't push this to 
reviewed until that goes too.
History
Date User Action Args
2011-04-07 17:28:27koweycreate
2011-05-10 12:30:51galbollesetstatus: needs-screening -> followup-requested
assignedto: kowey
messages: + msg14024
2011-06-08 19:45:44ganeshsetstatus: followup-requested -> accepted-pending-tests
messages: + msg14507
2011-10-12 06:23:47ganeshsetstatus: accepted-pending-tests -> accepted