darcs

Patch 66 hlint: span instead of break

Title hlint: span instead of break
Superseder Nosy List darcs-users, darcswatch, kowey, nomeata
Related Issues
Status accepted Assigned To
Milestone

Created on 2009-11-15.14:32:19 by nomeata, last changed 2011-05-10.20:05:38 by darcswatch.

Files
File name Status Uploaded Type Edit Remove
hlint_-span-instead-of-break.dpatch nomeata, 2009-11-15.14:32:19 text/x-darcs-patch
unnamed nomeata, 2009-11-15.14:32:19 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg9298 (view) Author: nomeata Date: 2009-11-15.14:32:19
Hi,

Sun Nov 15 15:24:04 CET 2009  Joachim Breitner <mail@joachim-breitner.de>
  * hlint: span instead of break
  (darcswatch/roundup integration test patch, but still useful)

Greetings,
Joachim
Attachments
msg9303 (view) Author: kowey Date: 2009-11-15.15:44:27
hlint: span instead of break
----------------------------
> - -      (curSpace, afterCurSpace) = break (not . (== ' ')) s
> +      (curSpace, afterCurSpace) = span (== ' ') s
>        (curWord,  afterCurWord)  = break (== ' ') afterCurSpace

I've pushed it, although it's a tiny bit sad because we somewhat lose
the symmetry between break and break not.  Bah, minor detail and could
be argued that hlint is right and it's cleaner.

Very deliberately not marking this accepted, hoping that darcswatch
will do it for us.

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
msg9304 (view) Author: darcswatch Date: 2009-11-15.15:47:48
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch <http://darcswatch.nomeata.de/repo_http:__darcs.net_.html>.
msg10379 (view) Author: darcswatch Date: 2010-03-21.14:19:56
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-09db73810c346e4a983cfe4685dc72792c3a466b
msg10380 (view) Author: darcswatch Date: 2010-03-21.14:21:48
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-09db73810c346e4a983cfe4685dc72792c3a466b
msg14231 (view) Author: darcswatch Date: 2011-05-10.20:05:38
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-09db73810c346e4a983cfe4685dc72792c3a466b
History
Date User Action Args
2009-11-15 14:32:19nomeatacreate
2009-11-15 15:44:30koweysetnosy: + kowey
messages: + msg9303
2009-11-15 15:47:51darcswatchsetstatus: needs-review -> accepted
messages: + msg9304
2010-03-21 14:19:56darcswatchsetmessages: + msg10379
2010-03-21 14:21:48darcswatchsetmessages: + msg10380
2011-05-10 20:05:38darcswatchsetmessages: + msg14231